Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles dark background box #1425

Open
gwenvador opened this issue Jun 17, 2020 · 18 comments
Open

Subtitles dark background box #1425

gwenvador opened this issue Jun 17, 2020 · 18 comments
Labels
bug Something isn't working confirmed The issue has been verified

Comments

@gwenvador
Copy link

Describe the bug
When playing a video on webclient there is a transparent black box in the background with the subtitles.

Expected behavior
There should not be a background black box.

Screenshots
https://i.imgur.com/hBClWUz.png

System (please complete the following information):

  • OS: MAC OS Catalina
  • Browser: Brave/Chrome (box spreading the full width), safari (around the subtitle)
  • Jellyfin Version: 10.5.5

Additional context
There is a reddit post on this issue but not resolved or reported on github: https://www.reddit.com/r/jellyfin/comments/ghwswp/deactivate_subtitle_backgroundbox/

@gwenvador gwenvador added the bug Something isn't working label Jun 17, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

Also seems to be occurring in Microsoft Edge with the full width box.
(Here's a screenshot.)

@gwenvador
Copy link
Author

I guess you are on windows? What's your full config?

@heyhippari
Copy link
Contributor

I'm not able to reproduce this on unstable (10.6).

Could one of you try, so we can confirm if this still happens or not? (Make sure to backup you current database)

@ghost
Copy link

ghost commented Jul 4, 2020

I guess you are on windows? What's your full config?

I am on macOS 10.15.5, Jellyfin 10.5.5 stable.
(I would test it on unstable but I don't see a build for macOS)

@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Jul 7, 2020

I found that iOS has some styling: Settings > Accessibility > Subtitles & Captioning > Style.
macOS has similar in System Settings.
If this is the case, then I believe that we cannot change this with either CSS or JS.

If only someone can provide ShadowDOM of videoplayer. Maybe some pseudo elements could be tuned.

@heyhippari
Copy link
Contributor

It's likely to be either -webkit-media-text-track-container, -webkit-media-text-track-display or cue.

Given the screenshot, my guess would be on -webkit-media-text-track-display.

@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Jul 7, 2020

Tried changing background-color with custom CSS.
::-webkit-media-text-track-container affects the entire screen.
::-webkit-media-text-track-display affects the lines occupied by subtitles.
::cue we already made it transparent.

Also tried changing style in iOS settings on iPad - it overrides our style.

So either there are other pseudo-elements in iOS, or it is impossible to do this.

@heyhippari
Copy link
Contributor

heyhippari commented Jul 7, 2020

@dmitrylyzo There's apparently a -webkit-media-text-track-display-backdrop specific to Safari.

Edit: It also needs !important

@dmitrylyzo
Copy link
Contributor

On iPhone 5S ::-webkit-media-text-track-display-backdrop{background-color:red!important} produces red background, as expected. But this doesn't work on iPad Pro.

But... if I select "Classic" predefined style, our style works.

@ghost
Copy link

ghost commented Aug 18, 2020

macOS has this page in accessibility settings:
Screenshot 08-18-2020 at 15 13 48@2x
Changing those settings to remove the background and making the size small improves the caption... but it lowers it down below the bottom edge of the video, which cuts off completely on longer lines.
Screenshot 08-18-2020 at 15 13 00@2x

@dmitrylyzo
Copy link
Contributor

@mattgeowild Have you tried Classic option?

@vedhavyas
Copy link

i have tried the classic option but it still the same

@dannymichel
Copy link
Contributor

I'm sure there's a way to get rid of it within the app and not in our operating system settings as Emby and plex have done it. Emby even gives you an option to control the background opacity. I know this isn't Emby. Just saying it's possible

@Arche151
Copy link

Arche151 commented Oct 9, 2023

Same issue here...

@RayJameson
Copy link

RayJameson commented Dec 30, 2023

same issue here on MacOS Sonoma 14.2.1 (23C71), Jellyfin version 10.8.13

UPD. Setting to Captures "Classic" in Accessibility settings helped for now

@ealcantara22
Copy link

I use brave browser so this should work for other Chromium base browsers in MacOS. Like some of the responses above, create a new accessibility caption entry checking the Allow video to override checkbox for all options. Save and restart your browser.

image

image

image

@ShaleenAg
Copy link

ShaleenAg commented Apr 27, 2024

Still facing this issue even after creating a custom Caption entry and disabling background color using Edge and Mac OS 13

EDIT: a restart fixed it

@manipEgo
Copy link

Just confirmed that the same problem on Win11 is also caused by the accessibility settings. A restart is also needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified
Projects
None yet
Development

No branches or pull requests