Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide multiple versions of same movie #3361

Open
Thalhammer opened this issue Jun 17, 2020 · 35 comments
Open

Hide multiple versions of same movie #3361

Thalhammer opened this issue Jun 17, 2020 · 35 comments
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed

Comments

@Thalhammer
Copy link

Describe the bug
If a movie is added in multiple versions it shows up multiple times in the search/list ui.
All versions with the number of version in the top corner.

System (please complete the following information):

  • OS: Ubuntu 18.04
  • Virtualization: LXC (Proxmox VE 6.2)
  • Clients: Browser; Android
  • Browser: Chrome 83
  • Jellyfin Version: 10.5.5
  • Playback: None
  • Installed Plugins:AudioDB;Fanart;IPTV;MusicBrainz;Playback Reporting;Reports
  • Reverse Proxy: none
  • Base URL: none
  • Networking: Direct via Linux Bridge
  • Storage: NFS to VM on the same VM Host (FreeNAS)

To Reproduce

  1. Put movies with the same name + version postfix in mediafolder.
  2. Let it scan them
  3. Go through media collection and group duplicates
  4. View Media List/Search for title

Expected behavior
The Title shows up once, with both versions available when opening the details.

Seen behavior
The title shows up twice, both with the indicator for multiple versions and clicking on any of them
shows the version selection (So it definitly understood that they both belong together).

Logs
Screenshots
See below

Additional context
I do not have both movies in a folder named after the movie as I would need to move a lot of files and would break other software accessing the library. However I have all movies in a single folder and group them manually through the ui.
I am not sure if this is a bug or the intended behavior, but it is intended, I believe there should be an option to hide those duplicates on the UI (which I could not find anywhere).

@Thalhammer Thalhammer added the bug Something isn't working label Jun 17, 2020
@1024mb
Copy link

1024mb commented Jun 18, 2020

Yes, this has been happening for quite some time, would be nice to have a fix for this.

@Thalhammer
Copy link
Author

I do have experience with C# / Javascript development.
Any hints on where to start if I where to try fixing this myself ?

@anthonylavado
Copy link
Member

This is mostly inherited behaviour, which we haven't changed. I think there's already a proposal to auto identify qualities and group them that way, using the codec/quality as the identifying marker.

I don't know where you'd work on this though - it would need implementation in the server and in the web interface, then the clients, etc...

@Thalhammer
Copy link
Author

I don't think you'd actually need to change the clients, I think it would be enough to remove the duplicate item from the list returned when listing movies.

@anthonylavado
Copy link
Member

You're right - I was confusing this with the logic to select a version to playback as well. Anyway...

@Thalhammer
Copy link
Author

@holow29 I dont think so. The issue you linked is about individual files not getting group automatically. My issue is about the files still showing up as two titles after being grouped manually (both with the group marking), where IMHO the gui should only show one entry for the group.

@holow29
Copy link
Contributor

holow29 commented Sep 7, 2020

@Thalhammer you're right. I think the issues are similar in that they deal with grouping of different versions malfunctioning but not the same.

@danieladov
Copy link
Contributor

This only occurs when grouping movies into collections is enabled

@stale
Copy link

stale bot commented Jan 19, 2021

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale Stale and will be closed if no activity occurs label Jan 19, 2021
@Thalhammer
Copy link
Author

It still exists....

@stale stale bot removed the stale Stale and will be closed if no activity occurs label Jan 19, 2021
@iFloris
Copy link

iFloris commented Jan 24, 2021

@Thalhammer this can be mitigated somewhat by using the mergeversions plugin; we use that and it works well, even for separated HD/4K libraries.

https://github.com/danieladov/jellyfin-plugin-mergeversions

@Thalhammer
Copy link
Author

It feels like #5324 should have fixed this, but for me the issue still persists. I am using version 10.7.0 from docker (jellyfin/jellyfin, not the linuxservers one).
I also tried ungrouping and regrouping some movies, which did nothing.
@iFloris I dont care if I have to manually group them (I dont add new media that often and when I do, converting takes way more time than grouping them afterwards), the issue is that even grouped they show twice pretty much everywhere.

@cvium
Copy link
Member

cvium commented Mar 20, 2021

#5324 is slated for a 10.7.1 release fyi

@Thalhammer
Copy link
Author

Fixed by 10.7.1

@1024mb
Copy link

1024mb commented Apr 21, 2021

@Thalhammer

It is not entirely fixed. If two individual non-collection movies are grouped there is no problem now, but if those movies are inside a Collection they are shown twice like before the fix. See pic.

alien collection

Please, re-open the issue.

@Thalhammer
Copy link
Author

Sorry, did not know that.

@Thalhammer Thalhammer reopened this Apr 22, 2021
@1024mb
Copy link

1024mb commented May 5, 2021

To update: Even with movies that aren't in a collection the issue is still present. I'm using 10.7.5 (Jellyfin says 10.8.0).

firefox_2021-05-05_17-48-08

@BugFixesAndPerformanceImprovements

As a suggestion: make this a toggle in the dashboard as having movies display for each duplicate file is a handy way to spot them in (very) large libraries.

@Lakeland97
Copy link

Screenshot_20211113-010131
Same issue here

@halictuz
Copy link

halictuz commented Nov 21, 2021

Same here. Even the correct naming on the folders/files doesn't seem to work correctly. They just don't group as one. Though... if I have two versions of a Movie and I click on the group option they actually have the drop down menu to choose from both versions. This works. But they still show up as seperate entries/movies in the Library and Collections.

@1337haXXor
Copy link

1337haXXor commented Apr 16, 2022

I didn't want to create a new issue, because I believe it's the same. Here's my setup:
Movies
└── Donnie Darko (2001) [4K] {Arrow}
└── extras
│ └── Special Feature 1.mkv
│ └── Special Feature 2.mkv
├── Donnie Darko - [Theatrical].mkv
└── Donnie Darko - [Director's Cut].mkv

I performed a rescan, but I have twice the problems. The movie is displaying twice in the library with no dropdown option. Additionally, all of those special features are showing in my movie library, which indicates to me there's a problem with the naming. When I FIRST migrated my library to accommodate jellyfin formatting, I had a few movie folders with the year first (1940 - Fantasia), and I noticed that all the special features, even when in an "extras" folder, showed up in the library. But when I fixed the root movie folder name, the extras worked properly.

So I guess there's something with the naming? I tried changing the folder to remove the [4K] and {Arrow} tags and did a rescan after each, but still nothing.

EDIT: Well, I figured out why it was messing up the structure. I read randomly on another comment, that the file names have to match the folder name, THEN the extra bits go after hyphen. So that's cool. Why does it have to be this way? For individual movies, I can have:

Movies
└── Zatoichi(2003) [DVD] {Miramax}
└── Zatoichi.mkv

And the file name doesn't have to match the folder. But with multiples, I have to add all my folder tags into the file name, like this?:

Movies
└── Donnie Darko (2001) [4K] {Arrow}
└── extras
│ └── Special Feature 1.mkv
│ └── Special Feature 2.mkv
├── Donnie Darko (2001) [4K] {Arrow} - [Theatrical].mkv
└── Donnie Darko (2001) [4K] {Arrow} - [Director's Cut].mkv

I'm glad I got it working, but this doesn't seem ideal.

@GodTamIt
Copy link
Contributor

I have another use-case that seems to break as well.

Example for TV:

TV/
  Breaking Bad (2008)/
    Season 01 - 1080p /
      Breaking Bad (2008) - s01e01.mkv
    Season 01 - 2160p AV1/
      Breaking Bad (2008) - s01e01.mkv

Currently, this results in two entries for each episode in Season 1. Instead, we should just group them together.

@Shadowghost
Copy link
Contributor

Multiple versions are not supported for episodes so this is expected.

@xenago
Copy link

xenago commented Dec 27, 2022

This would be a great feature. It's baffling that the scanner can identify two files as being the same film but does not combine them

@nickspacemonkey
Copy link

There is a workaround for this on reddit: https://www.reddit.com/r/jellyfin/comments/11o3nwa/how_to_handle_multiple_movie_versions_and/?utm_source=share&utm_medium=web2x&context=3

Although there seems to be some contention as to whether or not this is a bug, or if people are not following the naming conventions correcty.

@Thalhammer
Copy link
Author

Although there seems to be some contention as to whether or not this is a bug, or if people are not following the naming conventions correcty.

I don't think thats the same issue. The issue here is that despite the movie/show being grouped (i.e. jellyfin correctly knows its the same and lists the versions in the movie details page) it still shows two entries for this movie. It seems to be fixed since 10.7.1 for the main views and I can't verify the collections issue because I don't use collections.

@xenago
Copy link

xenago commented Mar 15, 2023

It's definitely still a problem in the main release in the main library sections. It will still match multiple copies of the same item and not combine them:

image

It ought to be fixable, since the scanner is correctly matching the films, just not combining them (even though the files are all being matched to the same exact film in TMDB).

This plugin seems to do it, so presumably something like it could be added:

https://github.com/danieladov/jellyfin-plugin-mergeversions

@Bond-009
Copy link
Member

@xenago Please give your file structure

@xenago
Copy link

xenago commented Mar 16, 2023

File structure is irrelevant to this issue (if a specific file structure is required beyond simply placing each movie in a folder, then that needs to be fixed as well since JF is currently able to match each file just fine), each of the films is matching to the same TMDB ID and therefore should be combined since JF is completely aware they are the same. I used the plugin for now until this is fixed properly.

All that is required here is for the scanner to check if an item already exists when scanning, and to combine rather than add as a separate entry. I am struggling to understand how this has not already been implemented when the plugin exists.

@Thalhammer
Copy link
Author

It's definitely still a problem in the main release in the main library sections. It will still match multiple copies of the same item and not combine them:

Thats a separate issue though. This issue was about grouped items showing multiple times, not about same movies not being automatically grouped, which while still a bad thing is less of an issue IMHO because you can just manually group them.

@Bond-009
Copy link
Member

@Thalhammer Is right, and I haven't really seen examples of the original issue since the fix so I think this issue can be closed?

@rodhfr
Copy link

rodhfr commented Jul 18, 2023

for me the issue was there (i'm using linuxserver docker container) but as commented above this plugin solved:
https://github.com/danieladov/jellyfin-plugin-mergeversions
image
image

@Thalhammer Thalhammer changed the title Hide multple versions of same movie Hide multiple versions of same movie Jul 19, 2023
@saberblaze
Copy link

One thing I don't think I've seen mentioned is that when there is a movie with 2 versions in one folder that also has an extras folder, the extras folder is not picked up by Jellyfin. The movies shows up twice in the library but no extras are shown. If I follow Jellyfin naming guide with identical names and dash at the end, the extras do show up. The mergeversions plugin avoids having to rename hundreds of files however the Jellyfin bug that prevents the extras from being picked up is present regardless of wheter the plugin is used or not. I'm not sure if opening a new issue is warranted or if it all falls under the same umbrella.

Ideally, it would be nice if Jellyfin can incorporate the mergeversions plugin functionality to avoid duplicate entries in the library and in collections while also making sure that the extras folder is properly picked up when there are multiple movie versions present.

@tromphakvoort
Copy link

I had the same issue with episodes where I have a low quality version and a high quality version, the plugin mentioned before did the trick. https://github.com/danieladov/jellyfin-plugin-mergeversions

@Panda260
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed
Projects
Status: Todo
Development

No branches or pull requests