-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromecast still showing Emby name #402
Comments
Hmmm... looking into this, I see no strings that match "Emby" in the DLNA code. Can you perhaps include a picture of this screen? I don't own a Chromecast so I'm working blind without one. Edit: And are you using master or dev? Can you check if latest dev fixes the problem? |
Does using the latest dev fix this issue? I ask because that's the code I'm looking through for "Emby." |
It's almost certainly due to this line: Line 95 in 21a8d27
Namely: "2D4B1DA3" is a Chromecast app I'd, something you have to register and publish with Google to create a chromecast app. This is clearly the Emby app. We need to make.our own but iirc there's no source to fork |
Ah... well, that's why I couldn't find it. Guess that's yet another thing to add to our long todo list huh? |
@sparky8251 I stand corrected found many a fork we can fork List:
(This last one above is the most recent one I found (2 years)) Cordova plugins: |
Well, the Cordova ones aren't licensed under anything and are therefore unusable. The other four are MIT and GPL. So we have somewhere to start at least. |
Grabbed the latest of each of the Chromecast apps, but not Cordova for the reasons @sparky8251 mentioned. |
Wow that second Cordova's upstream never had a license to begin with, so how would he fork it and use it? |
@anthonylavado Because who cares about things being properly licensed, right? right?! |
Fixed by jellyfin/jellyfin-chromecast#1 and jellyfin/jellyfin-web@edde580 in the latest dev branches slated for 10.0.2 release afaik. |
Just a small issue when you get to the small issue pile... :-)
The splash screen that comes up on your TV when you select to Chromecast to a (real) Chromecast device still displays "Emby", as does the chrome browser extension widget.
The text was updated successfully, but these errors were encountered: