Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast still showing Emby name #402

Closed
brianjmurrell opened this issue Jan 4, 2019 · 11 comments · Fixed by #592
Closed

Chromecast still showing Emby name #402

brianjmurrell opened this issue Jan 4, 2019 · 11 comments · Fixed by #592
Labels
feature Adding a new feature, or substantial improvements on existing functionality

Comments

@brianjmurrell
Copy link
Contributor

Just a small issue when you get to the small issue pile... :-)

The splash screen that comes up on your TV when you select to Chromecast to a (real) Chromecast device still displays "Emby", as does the chrome browser extension widget.

@sparky8251
Copy link
Contributor

sparky8251 commented Jan 4, 2019

Hmmm... looking into this, I see no strings that match "Emby" in the DLNA code.

Can you perhaps include a picture of this screen? I don't own a Chromecast so I'm working blind without one.

Edit: And are you using master or dev? Can you check if latest dev fixes the problem?

@brianjmurrell
Copy link
Contributor Author

Here's a screenshot of the Chromecast extension's widget in Google Chrome once Jellyfin has been asked to Chromecast:

image

I'm using the 3.5.2 release.

@sparky8251
Copy link
Contributor

Does using the latest dev fix this issue? I ask because that's the code I'm looking through for "Emby."

@bfayers
Copy link
Contributor

bfayers commented Jan 5, 2019

It's almost certainly due to this line:

Namely: chrome.cast.SessionRequest("2D4B1DA3")

"2D4B1DA3" is a Chromecast app I'd, something you have to register and publish with Google to create a chromecast app. This is clearly the Emby app. We need to make.our own but iirc there's no source to fork

@sparky8251
Copy link
Contributor

Ah... well, that's why I couldn't find it. Guess that's yet another thing to add to our long todo list huh?

@sparky8251
Copy link
Contributor

Well, the Cordova ones aren't licensed under anything and are therefore unusable.

The other four are MIT and GPL. So we have somewhere to start at least.

@joshuaboniface
Copy link
Member

Grabbed the latest of each of the Chromecast apps, but not Cordova for the reasons @sparky8251 mentioned.

@anthonylavado anthonylavado added fork feature Adding a new feature, or substantial improvements on existing functionality labels Jan 5, 2019
@anthonylavado
Copy link
Member

Wow that second Cordova's upstream never had a license to begin with, so how would he fork it and use it?

@bfayers
Copy link
Contributor

bfayers commented Jan 5, 2019

@anthonylavado Because who cares about things being properly licensed, right? right?!

@cvium
Copy link
Member

cvium commented Jan 14, 2019

Fixed by jellyfin/jellyfin-chromecast#1 and jellyfin/jellyfin-web@edde580 in the latest dev branches slated for 10.0.2 release afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding a new feature, or substantial improvements on existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants