Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /Device endpoint to return CustomName #10422

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

scampower3
Copy link
Member

@scampower3 scampower3 commented Oct 17, 2023

Changes
Adds CustomName to /Devices API endpoint
Related to jellyfin/jellyfin-web#4887

Issues

@github-actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /Devices/Info
Return Type:

Changed response : 200 OK

Device info retrieved.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Added property CustomName (string)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Added property CustomName (string)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Added property CustomName (string)

GET /Devices
Return Type:

Changed response : 200 OK

Devices retrieved.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Added property CustomName (string)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Added property CustomName (string)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Added property CustomName (string)

@scampower3 scampower3 marked this pull request as draft October 17, 2023 09:59
@scampower3 scampower3 marked this pull request as ready for review October 17, 2023 10:08
@scampower3 scampower3 marked this pull request as draft October 17, 2023 10:30
@scampower3 scampower3 marked this pull request as ready for review October 17, 2023 16:42
Copy link

@gaurovgiri gaurovgiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JPVenson JPVenson added enhancement Improving an existing function, or small fixes backend Related to the server backend ui & ux This PR or issue mainly concerns UI & UX labels Nov 30, 2023
@Bond-009 Bond-009 merged commit 2137477 into jellyfin:master Dec 18, 2023
24 checks passed
@scampower3 scampower3 deleted the api-update branch December 20, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the server backend enhancement Improving an existing function, or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants