Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Change client to extend event emitter #26

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Change client to extend event emitter #26

merged 6 commits into from
Apr 14, 2023

Conversation

ostatni5
Copy link
Contributor

No description provided.

@ostatni5 ostatni5 self-assigned this Mar 22, 2023
@ostatni5 ostatni5 marked this pull request as ready for review March 23, 2023 10:41
kamil-stasiak
kamil-stasiak suggested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@kamil-stasiak kamil-stasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to also add Evenr emitter to TrackContext

  onEncodingChanged?: (this: TrackContext) => void;
  onVoiceActivityChanged?: (this: TrackContext) => void;

@kamil-stasiak kamil-stasiak force-pushed the Change-client-to-extend-event-emitter branch from 2e83dbb to f7d2b31 Compare March 27, 2023 05:58
@kamil-stasiak kamil-stasiak merged commit 2204589 into master Apr 14, 2023
@kamil-stasiak kamil-stasiak deleted the Change-client-to-extend-event-emitter branch April 14, 2023 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kamil-stasiak kamil-stasiak kamil-stasiak approved these changes

@mickel8 mickel8 Awaiting requested review from mickel8

Assignees

@ostatni5 ostatni5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostatni5 @kamil-stasiak