Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching #6

Closed
jemus42 opened this issue Jul 6, 2014 · 1 comment
Closed

Implement caching #6

jemus42 opened this issue Jul 6, 2014 · 1 comment

Comments

@jemus42
Copy link
Owner

jemus42 commented Jul 6, 2014

First up: The way deployment to shinyapps.io works is that everything the application writes to disk does not survive consecutive deployments, i.e. the vm the app runs in gets destroyed and a new one is created. Therefore caching is even more temporary that one would assume.

However, I think we should create a cache dir, and every series dataset that gets pulled should be saved in the most efficient way (either via save or saveRDS, which would probably be more flexible) to said directory, and on startup the app should be able to compare the query (or download the search result and then compare id_tvdb or something) and if the dataset is present in cache, read the data from there.

We could also download some popular series' data and permanently commit it to the repository, as example data. This would probably be helpful for debugging purposes as well.

@jemus42
Copy link
Owner Author

jemus42 commented Jul 7, 2014

Done

@jemus42 jemus42 closed this as completed Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant