chore: disable publication from ci.jenkins.io #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
commented
Feb 9, 2024
Comment on lines
+1
to
+2
| @Library('pipeline-library@pull/784/head') _ | ||
|
|
There was a problem hiding this comment.
Suggested change
| @Library('pipeline-library@pull/784/head') _ |
To be removed in a future PR when jenkins-infra/pipeline-library#784 will be merged.
EDIT:
|
Cherry-picked #353 commit to get a passing job. |
timja
approved these changes
Feb 10, 2024
dduportal
reviewed
Feb 12, 2024
Comment on lines
+1
to
+5
| buildDockerAndPublishImage('account-app', [ | ||
| rebuildImageOnPeriodicJob: false, | ||
| automaticSemanticVersioning: true, | ||
| targetplatforms: 'linux/amd64,linux/arm64' | ||
| ]) |
There was a problem hiding this comment.
We should merge these 2 pipelines into a single one to ensure the same set of parameters is applied to both CI and CD process (and avoid CD issues which could have been caught by CI).
=> WDYT about the method you used (can't remember where though): disablePublication: !infra.isInfra() ?
There was a problem hiding this comment.
This is the next step.
First I needed to be sure that my pipeline change worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables tagging and publication of docker image and github release from ci.jenkins.io
The merge of this PR will also serve as a test for jenkins-infra/pipeline-library#784
Ref: