-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(buildDockerAndPublishImage): add optional disablePublication
parameter
#784
feat(buildDockerAndPublishImage): add optional disablePublication
parameter
#784
Conversation
…mage` (#142) * feat(build): use `buildDockerAndPublishImage` * fix hadolint * cleanup pushToDocker * restore indentation * use docker to build only when not on infra.ci * also stash when not on infra * Test jenkins-infra/pipeline-library#784 * fixup * buildDockerAndPublishImage on infra.ci only for now * remove unused ci.j stash, and stash only the jar in the infra.ci one * restore blank line * restore blank line again
febdd25
to
5e3e4a6
Compare
5e3e4a6
to
ca40b7c
Compare
enablePublication
parameterdisablePublication
parameter
Tested with jenkins-infra/account-app#351 Confirmed working as expected: https://ci.jenkins.io/job/Infra/job/account-app/job/main/167/pipeline-console/log?nodeId=87
The main branch job passed on ci.jenkins.io. |
A nice follow-up feature would be to disable publication if the merged pull request had a specific label (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a parameter to disable tagging and publication of docker image(s) and github release.
Use case: running the same pipeline on both ci.jenkins.io and infra.ci.jenkins.io
Tested with jenkins-infra/account-app#351
Confirmed working as expected: https://ci.jenkins.io/job/Infra/job/account-app/job/main/167/pipeline-console/log?nodeId=87
The main branch job passed on ci.jenkins.io.
Ref:
infra.ci.jenkins.io
and usebuildDockerAndPublishImage
plugin-site-api#142