feat(buildDockerAndPublishImage): add optional disablePublication parameter
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
added a commit
to jenkinsci/jenkins-infra-test-plugin
that referenced
this pull request
Nov 13, 2023
lemeurherve
added a commit
to lemeurherve/plugin-site-api
that referenced
this pull request
Nov 13, 2023
lemeurherve
added a commit
to jenkins-infra/plugin-site-api
that referenced
this pull request
Nov 13, 2023
…mage` (#142) * feat(build): use `buildDockerAndPublishImage` * fix hadolint * cleanup pushToDocker * restore indentation * use docker to build only when not on infra.ci * also stash when not on infra * Test jenkins-infra/pipeline-library#784 * fixup * buildDockerAndPublishImage on infra.ci only for now * remove unused ci.j stash, and stash only the jar in the infra.ci one * restore blank line * restore blank line again
lemeurherve
force-pushed
the
allow-disable-publish-image
branch
from
febdd25
to
5e3e4a6
Compare
lemeurherve
force-pushed
the
allow-disable-publish-image
branch
from
5e3e4a6
to
ca40b7c
Compare
lemeurherve
changed the title
enablePublication parameterdisablePublication parameter
|
Tested with jenkins-infra/account-app#351 Confirmed working as expected: https://ci.jenkins.io/job/Infra/job/account-app/job/main/167/pipeline-console/log?nodeId=87
The main branch job passed on ci.jenkins.io. |
|
A nice follow-up feature would be to disable publication if the merged pull request had a specific label (like |
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a parameter to disable tagging and publication of docker image(s) and github release.
Use case: running the same pipeline on both ci.jenkins.io and infra.ci.jenkins.io
Tested with jenkins-infra/account-app#351
Confirmed working as expected: https://ci.jenkins.io/job/Infra/job/account-app/job/main/167/pipeline-console/log?nodeId=87
The main branch job passed on ci.jenkins.io.
Ref:
infra.ci.jenkins.ioand usebuildDockerAndPublishImageplugin-site-api#142