Configure account-app through env variables #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to run this application without having to mount an external files (/etc/config.properties) which simply application deployment in an environment like kubernetes It still work the old way. We do not generate /etc/config.popreties if it's already mounted
|
The container being built by the |
Deletedir Fix file name because gitignore
|
-_- who did invent gitignore files |
rtyler
reviewed
Apr 14, 2017
|
/me is closing&reopening the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove strong dependency on external volumes.
All configuration can be done through env variables
It simplifies application deployment in an environment like kubernetes
Anyway it still work the old way.
We do not generate /etc/config.properties if it's already mounted