Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure account-app through env variables #99

Closed
wants to merge 5 commits into from

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 13, 2017

This PR remove strong dependency on external volumes.
All configuration can be done through env variables
It simplifies application deployment in an environment like kubernetes

Anyway it still work the old way.
We do not generate /etc/config.properties if it's already mounted

	Allow to run this application without having to mount an external files
	(/etc/config.properties)
	which simply application deployment in an environment like kubernetes

	It still work the old way.
	We do not generate /etc/config.popreties if it's already mounted
@rtyler
Copy link
Member

rtyler commented Apr 13, 2017

The container being built by the Jenkinsfile (which is what gets pushed to Docker Hub) is failing to build.

@olblak
Copy link
Member Author

olblak commented Apr 14, 2017

-_- who did invent gitignore files

Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ruby-based test tooling I don't fully understand, if you think it's important, why not add it to the Jenkinsfile?

@olblak
Copy link
Member Author

olblak commented Apr 14, 2017

/me is closing&reopening the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants