Add application configuration through env variables #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* .gitignore: Add .env file used by docker-compose
for env variables
* Add docker-compose for testing environment
* Update documentation
* Add an entrypoint script
* Template config.properties if the file
doesn't exist
|
There are two reasons to that and both are my fault.
|
|
@olblak That Jenkinsfile behavior tripped me up before 😄 Thanks! |
rtyler
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add an additional way to configure 'accountapp' trough environment variables that simplify deployment on kubernetes cluster.
I added a docker-compose file only for testing purpose.
! This PR doesn't take into account #96 as it is not up to date with master.