Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vnets) add a subnet for ci.jenkins.io controller in the sponsored subscription #195

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jan 18, 2024

Ref. jenkins-infra/helpdesk#3908 (comment)

This PR adds a dedicated subnet for ci.jenkins.io controller in the new subscription

…d subscription

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review January 18, 2024 11:44
@dduportal dduportal requested review from a team, timja, lemeurherve and smerle33 January 18, 2024 11:44
@dduportal
Copy link
Contributor Author

(note the IP change is because I've updated my public IP as I'm in the train: no problem to have terraform rollback my manual change)!

Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan LGTM

@dduportal dduportal merged commit db45f89 into jenkins-infra:main Jan 18, 2024
2 checks passed
@dduportal dduportal deleted the feat/vnets/add-ci-controller-sponsorship branch January 18, 2024 11:56
dduportal added a commit to jenkins-infra/azure that referenced this pull request Jan 22, 2024
…roller to secondary sponsored subscription (#583)

Ref. jenkins-infra/helpdesk#3913

This PR adds a new ci.jenkins.io controller VM in the new subscription.

Blocked by:
- Subnet to add for the controller in the new subscription:
jenkins-infra/azure-net#195
- Update the terraform module for azure vm controllers to support
different AzureRM providers between resources and DNS records (Link to
be added)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants