Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci.jenkins.io) add a secondary (empty) VM to prepare moving controller to secondary sponsored subscription #583

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jan 18, 2024

Ref. jenkins-infra/helpdesk#3913

This PR adds a new ci.jenkins.io controller VM in the new subscription.

Blocked by:

…econdary sponsored subscription of the controller

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review January 22, 2024 17:24
@dduportal dduportal requested a review from a team as a code owner January 22, 2024 17:24
@dduportal
Copy link
Contributor Author

Self merging:

  • It only creates new resources in the new subscription
  • A backup of ci.jenkins.io data has been taken just in case

@dduportal dduportal merged commit e2982f3 into jenkins-infra:main Jan 22, 2024
2 checks passed
@dduportal dduportal deleted the feat/ci.jenkins.io/sponsored branch January 22, 2024 17:37
dduportal added a commit that referenced this pull request Jan 22, 2024
Fixup of #583 

This PR migrates the explicit RG definition for ci.jenkins.io controller
in the sponsored subscription into the new module introduced in #583

It also updates, along the way, references to new (properly named)
module output `controller_service_principal_id` instead of
`controler_service_principal_id`

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant