Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK21: change from nightly builds to weekly ea builds in the infra #3736

Closed
gounthar opened this issue Aug 29, 2023 · 5 comments
Closed

JDK21: change from nightly builds to weekly ea builds in the infra #3736

gounthar opened this issue Aug 29, 2023 · 5 comments

Comments

@gounthar
Copy link

Service(s)

ci.jenkins.io

Summary

  • EA builds are already used by Jenkins official images (for the jdk21-preview)
  • Allow tracking JDK21 version with updatecli
  • Should simplify the puppet configuration for our infra

Reproduction steps

No response

@gounthar gounthar added the triage Incoming issues that need review label Aug 29, 2023
@dduportal dduportal added this to the infra-team-sync-2023-09-05 milestone Aug 30, 2023
@dduportal dduportal removed the triage Incoming issues that need review label Aug 30, 2023
@dduportal
Copy link
Contributor

dduportal commented Aug 30, 2023


💡 As discussed together, we have to start with https://github.com/jenkins-infra/packer-images


A few details:

EA builds are already used by Jenkins official images (for the jdk21-preview)

Example: https://github.com/jenkinsci/docker/blob/f31b562b7346db0e2176acc7ed687458f08baf9f/21/debian/bookworm/hotspot/Dockerfile#L4-L18

Should simplify the puppet configuration for our infra

Files that might (or might not) need an update:

Allow tracking JDK21 version with updatecli

That one should be the last step of course :)

@smerle33
Copy link
Contributor

smerle33 commented Sep 5, 2023

💡 As discussed together, we have to start with https://github.com/jenkins-infra/packer-images

A few details:

EA builds are already used by Jenkins official images (for the jdk21-preview)

Example: https://github.com/jenkinsci/docker/blob/f31b562b7346db0e2176acc7ed687458f08baf9f/21/debian/bookworm/hotspot/Dockerfile#L4-L18

Should simplify the puppet configuration for our infra

Files that might (or might not) need an update:

* Puppet template which generates the temurin download URLs depending on the JDK version and platforms: https://github.com/jenkins-infra/jenkins-infra/blob/production/dist/profile/templates/jdk-adoptium-url.erb

* Puppet template which generates the JCasC configuration for JDK tool installation: ~https://github.com/jenkins-infra/jenkins-infra/blob/production/dist/profile/templates/jdk-adoptium-url.erb~ https://github.com/jenkins-infra/jenkins-infra/blob/production/dist/profile/templates/jenkinscontroller/casc/tools.yaml.erb

* Puppet "common" hieradata configuration (e.g. values passed to the aforementioned templates) for JDK21 for all controllers: https://github.com/jenkins-infra/jenkins-infra/blob/7d9447958f77d0186f70e3e8c54fd09bdfbf431f/hieradata/common.yaml#L205-L217

* Puppet "common" hieradata configuration (e.g. values passed to the aforementioned templates) for the usual JDK versions (that should be the only source of truth which `updatecli` should update): https://github.com/jenkins-infra/jenkins-infra/blob/7d9447958f77d0186f70e3e8c54fd09bdfbf431f/hieradata/common.yaml#L252-L257

* Puppet "addition" hieradata configuration for `ci.jenkins.io` only (merged with the common hieradata config) for JDK21: https://github.com/jenkins-infra/jenkins-infra/blob/7d9447958f77d0186f70e3e8c54fd09bdfbf431f/hieradata/clients/controller.ci.jenkins.io.yaml#L113-L126

Allow tracking JDK21 version with updatecli

That one should be the last step of course :)

I would add the vagrant common.yaml in hieradata to test the tools installation of the jdk21 with vagrant.

@smerle33
Copy link
Contributor

all set with jdk21: 21+35-ea-beta in puppet (jenkins-infra) and kubernetes-management with updatecli

@smerle33
Copy link
Contributor

reopening because of missing updatecli within packer-images for jdk21

@smerle33
Copy link
Contributor

can now be closed after jenkins-infra/packer-images#805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants