Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions file for groovy-sandbox #2602

Merged
merged 1 commit into from Jun 17, 2022

Conversation

dwnusbaum
Copy link
Contributor

@dwnusbaum dwnusbaum commented Jun 17, 2022

Description

https://github.com/jenkinsci/groovy-sandbox was moved into the jenkinsci org long ago, but it was still configured to use Kohsuke's parent POM and release to Maven Central. For the past four years this library has only been released to https://repo.jenkins-ci.org/, and only as part of Jenkins security advisories, which bypass the permissions set by this repository. I would like to be able to release this library to https://repo.jenkins-ci.org/ independently of security advisories.

For additional context, the last Maven Central release of the library was version 1.19 back in April 2018. However, even before that, versions 1.13 and 1.16, which were part of Jenkins security advisories, never got mirrored to Maven Central, leading to confusion for non-Jenkins consumers. In jenkinsci/groovy-sandbox#58 we updated the library's readme to indicate that all new versions would only be released to https://repo.jenkins-ci.org/releases, and later in jenkinsci/groovy-sandbox#63 we started explicitly discouraging all non-Jenkins usage of the library.

See also jenkinsci/groovy-sandbox#76. The users listed in the new permission file are users who are listed in permissions/script-security-plugin.yml (which should be the only plugin consuming groovy-sandbox) that are still active in the Jenkins project. Eventually I would like to move this library into https://github.com/jenkinsci/script-security-plugin, but it will need its own permissions file either way.

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command (Not needed)
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@dwnusbaum dwnusbaum requested a review from a team as a code owner June 17, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants