Switch parent POM to org.jenkins-ci:jenkins #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
requested review from
daniel-beck,
Wadeck,
yaroslavafenkin and
Kevin-CB
13 tasks
6 tasks
yaroslavafenkin
approved these changes
Jun 20, 2022
dwnusbaum
commented
Jun 20, 2022
| @@ -579,7 +579,7 @@ public static Object checkedBinaryOp(Object lhs, int op, Object rhs) throws Thro | |||
| public static Object checkedComparison(Object lhs, final int op, Object rhs) throws Throwable { | |||
| if (lhs==null) {// bypass the checker if lhs is null, as it will not result in any calls that will require protection anyway | |||
| return InvokerHelper.invokeStaticMethod(ScriptBytecodeAdapter.class, | |||
| Ops.binaryOperatorMethods(op), new Object[]{lhs,rhs}); | |||
| Ops.binaryOperatorMethods(op), new Object[]{null, rhs}); | |||
There was a problem hiding this comment.
Just to note, this was for SpotBugs (LOAD_OF_KNOWN_NULL_VALUE or whatever it is...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is currently configured to release to Maven central using Kohsuke's parent POM, but for the past 4 years or so, it has only been released as part of a Jenkins security fix directly to https://repo.jenkins-ci.org/ (note that in #63 we updated the README to explicitly discourage use of this library outside of Jenkins). This PR changes the parent POM to https://github.com/jenkinsci/pom so that we can release this library to https://repo.jenkins-ci.org/ under normal circumstances.
I will also file a PR to https://github.com/jenkins-infra/repository-permissions-updater to set up this libary.
Eventually I would like to turn https://github.com/jenkinsci-cert/script-security-plugin into a multi-module project with this library as one of the submodules, but I want to do things one step at a time.