fix: add webhook GUID for comments #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that lighthouse can use the webhook GUID when creating LighthouseJobs from comments, the same way it does with push events (right now lighthouse use the comment ID as the webhook GUID)
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstrachan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vbehar
added a commit
to vbehar/lighthouse
that referenced
this pull request
Apr 15, 2021
previously issues & pullrequests comments used the issue/pr ID as the event GUID related to jenkins-x/go-scm#267
vbehar
added a commit
to vbehar/go-scm
that referenced
this pull request
Apr 29, 2021
same as jenkins-x#267 but implemented for bitbucketcloud too now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that lighthouse can use the webhook GUID when creating LighthouseJobs from comments, the same way it does with push events
(right now lighthouse use the comment ID as the webhook GUID)