Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register domain in AWS when using the 'domain' option #1478

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

polothy
Copy link

@polothy polothy commented Aug 13, 2018

We were seeing different behavior when using the --domain option in jx create cluster eks vs not using it and manually entering it when prompted. With the option, the domain is not registered with a CNAME whereas when using the prompt, the domain does get a CNAME.

Assuming that the behavior should be the same regardless of where the domain comes from.

@jstrachan
Copy link
Member

@polothy great stuff thanks!

@jstrachan jstrachan merged commit d610927 into jenkins-x:master Aug 14, 2018
@polothy polothy deleted the aws-domain branch August 14, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants