ECR should take AWS_DEFAULT_REGION into account

[hekonsek]

Hi,

Right now when you create new application on AWS EKS, jx reads only AWS_REGION environment variable. At the same time jx install --provider=eks respects AWS_DEFAULT_REGION. As a result if you have only AWS_DEFAULT_REGION=us-east-1 set on your machine, jx will create EKS cluster in us-east-1, but new repositories will be created in us-west-1 (which is current default). Also application build respects original AWS_DEFAULT_REGION, so eventually application build fail on Jenkins as it tries to push repository in wrong region (west instead of east).

According to AWS CLI documentation AWS_DEFAULT_REGION is the proper env to set to indicate AWS region. However it is also common for tools to use AWS_REGION.

I propose then that ecr#NewAwsSession should respect both AWS_DEFAULT_REGION and AWS_REGION. This simple fix solves the problem.

[jenkins-x-bot]

Hi @hekonsek. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstrachan]

/approvd

[jstrachan]

/approve
might type it correctly this time ;)

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jstrachan]

/approved