fix(Jenkinsfile): cleanup the old github credential from Jenkinsfile #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test bdd |
…t varialbes from pipeline secrets
…uting the integration tests
rawlingsj
reviewed
Dec 17, 2018
| @@ -30,12 +30,14 @@ pipeline { | |||
| steps { | |||
| dir ('/home/jenkins/go/src/github.com/jenkins-x/jx') { | |||
| checkout scm | |||
| sh "git config --global credential.helper store" | |||
| sh "jx step git credentials" | |||
There was a problem hiding this comment.
I think we can remove these now that we use knative build creds init container. Credentials get automatically mounted now so I would have thought we could remove all
sh "git config --global credential.helper store"
sh "jx step git credentials"
…ith integration tests
|
/test bdd |
|
/test bdd |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawlingsj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter checklist
Description
Special notes for the reviewer(s)
Which issue this PR fixes
fixes #