New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Jenkinsfile): cleanup the old github credential from Jenkinsfile #2523

Merged
merged 11 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@ccojocar
Copy link
Member

ccojocar commented Dec 17, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from amuniz and wbrefvem Dec 17, 2018

@ccojocar ccojocar requested review from jstrachan and rawlingsj and removed request for amuniz and wbrefvem Dec 17, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 17, 2018

/test bdd

ccojocar added some commits Dec 17, 2018

@jenkins-x-bot jenkins-x-bot added size/L and removed size/XS labels Dec 17, 2018

@@ -30,12 +30,14 @@ pipeline {
steps {
dir ('/home/jenkins/go/src/github.com/jenkins-x/jx') {
checkout scm
sh "git config --global credential.helper store"
sh "jx step git credentials"

This comment has been minimized.

@rawlingsj

rawlingsj Dec 17, 2018

Member

I think we can remove these now that we use knative build creds init container. Credentials get automatically mounted now so I would have thought we could remove all

sh "git config --global credential.helper store"
sh "jx step git credentials"

This comment has been minimized.

@ccojocar

ccojocar Dec 17, 2018

Member

alright

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 17, 2018

/test bdd

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 17, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit c01a726 into jenkins-x:master Dec 17, 2018

1 of 2 checks passed

tide Not mergeable. Needs updatebot label.
Details
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment