fix for dev GitOps + serverless + jenkins plugin picker #3221
Conversation
lets properly preserve secrets generated from Apps like Prow / tekton and avoid incorrectly indenting them inside `jenkins-x-platform`
which we can then reuse in the Jenkins App to help configure the plugins on a custom Jenkins server
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test this |
| AllocatableStorage *resource.Quantity | ||
|
|
||
| CpuRequests resource.Quantity | ||
| CpuLimits resource.Quantity |
There was a problem hiding this comment.
struct field CpuLimits should be CPULimits
| AllocatableCPU *resource.Quantity | ||
| AllocatableStorage *resource.Quantity | ||
|
|
||
| CpuRequests resource.Quantity |
There was a problem hiding this comment.
struct field CpuRequests should be CPURequests
and report when data is missing
|
@jstrachan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test this |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawlingsj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.