[WIP] #818 Add Users to K8s resources with best-guess Email #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
commented
May 16, 2018
| } | ||
|
|
||
| func GitCommit(dir string, message string) error { |
There was a problem hiding this comment.
Renamed this since I think it made more sense as the commit object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #818 when complete by adding UserDetails as an independent K8s resource type, with some smarts to get the user's email populated. This will be kept up-to-date as the user submits pull requests, currently, and should probably be the source of truth for all user data instead of duplicating it across other K8s resource types.