Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename 'tasks' folder to 'task' #71

Closed
wants to merge 1 commit into from
Closed

fix: rename 'tasks' folder to 'task' #71

wants to merge 1 commit into from

Conversation

hervelemeur
Copy link
Contributor

@hervelemeur hervelemeur commented Dec 9, 2020

When running jx pipeline import --url https://github.com/jenkins-x/jx3-pipeline-catalog

I had this error:

loading tekton tasks from: https://github.com/jenkins-x/jx3-pipeline-catalog ...

error: the catalog does not include a 'task' directory at /var/folders/m4/ytp3wjnn1hlbrxt27d64jc3c0000gn/T/jx-git-658269897

Fixes #70

Signed-off-by: Hervé Le Meur herve.lemeur@sixense-group.com

Fixes #70

Signed-off-by: Hervé Le Meur <herve.lemeur@sixense-group.com>
@jenkins-x-bot-test
Copy link
Contributor

Hi @hervelemeur. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot-test
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hervelemeur
Copy link
Contributor Author

/assign @jstrachan

@hervelemeur hervelemeur changed the title fix: rename 'tasks' folder to avoid error #70 fix: rename 'tasks' folder to 'task' Dec 9, 2020
@hervelemeur
Copy link
Contributor Author

Slack thread

@jstrachan
Copy link
Member

incidentally we never intended the pipeline catalog to be usable as a tekton catalog; I guess though thats a natural thing for folks to think. The main issue is we didn't want to have to put a version name in the directory; as we're using git sha/branch/tags for versioning

@hervelemeur
Copy link
Contributor Author

replaced by #331

@hervelemeur hervelemeur closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "tasks" folder should be named "task"
3 participants