Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateItemTest#duplicate_item_name_displays_error fails on 2.453+ #1545

Closed
basil opened this issue May 14, 2024 · 1 comment · Fixed by #1547
Closed

CreateItemTest#duplicate_item_name_displays_error fails on 2.453+ #1545

basil opened this issue May 14, 2024 · 1 comment · Fixed by #1547
Labels

Comments

@basil
Copy link
Member

basil commented May 14, 2024

Starting with jenkinsci/jenkins#9111 by @janfaracik in 2.453, CreateItemTest#duplicate_item_name_displays_error fails with

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at core.CreateItemTest.duplicate_item_name_displays_error(CreateItemTest.java:47)

A possible short-term workaround (pending JENKINS-73034):

diff --git a/src/test/java/core/CreateItemTest.java b/src/test/java/core/CreateItemTest.java
index 27849e28..2df41601 100644
--- a/src/test/java/core/CreateItemTest.java
+++ b/src/test/java/core/CreateItemTest.java
@@ -44,7 +44,8 @@ public class CreateItemTest extends AbstractJUnitTest {
         assertTrue(find(EXISTING_NAME_MSG).isDisplayed());
 
         final WebElement okButtonElement = find(OK_BUTTON);
-        assertTrue(okButtonElement.isEnabled());
+        // TODO JENKINS-73034
+        //assertTrue(okButtonElement.isEnabled());
 
         okButtonElement.click();
         assertThat(driver, hasContent(JOB_CREATION_ERROR_MSG));
@basil
Copy link
Member Author

basil commented May 14, 2024

I have added a workaround in #1545. #1549 tracks the removal of this workaround as part of fixing JENKINS-73034.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant