Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-22252] Reproduced problem in test #41

Merged
merged 1 commit into from Oct 2, 2015

Conversation

Projects
None yet
7 participants
@jglick
Copy link
Member

commented Sep 30, 2015

@reviewbybees

This comment has been minimized.

Copy link

commented Sep 30, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -246,4 +248,20 @@ private void assertHasModule(MavenModuleSet job, String name) {
find(by.xpath("//a[@href='%s/']", name)).click();
assertThat(driver.getCurrentUrl(), equalTo(build.module(name).url.toExternalForm()));
}

@Issue("JENKINS-22252")
@WithPlugins({"maven-plugin@2.12", "tasks"})

This comment has been minimized.

Copy link
@amuniz

amuniz Sep 30, 2015

Member

Is the plugin version specified for some reason? If the plugin version is fixed here, then this test is not going to catch possible regressions in future versions.

This comment has been minimized.

Copy link
@amuniz

amuniz Sep 30, 2015

Member

Ok. This is actually reproducing the error exactly in this version. Nevermind.

This comment has been minimized.

Copy link
@amuniz

amuniz Sep 30, 2015

Member

Well, reading the code again... I think my initial question still makes sense 😄

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 1, 2015

Member

I suppose this version specification is a temporary thing and @jglick is going to update it to 2.13 after the release. Before that this test will be failing.

This comment has been minimized.

Copy link
@uhafner

uhafner Oct 1, 2015

Member

Shouldn't this be the initial version required to get the test running? I.e., 2.12-SNAPSHOT or 2.13? It is not required to change it when 2.13 has been released. So we can better see in which version the fix has been applied.

This comment has been minimized.

Copy link
@olivergondza

olivergondza Oct 1, 2015

Member

It should be the first version where necessary features was introduced. As it is a regression introduced in 2.12 IIUC, there should be no version specified (presuming it does not depend on any recent features).

As a rule of thumb, consider someone is running this against a plugin version with JENKINS-22252 present. If we declare this should run with first fixed version we effectively hide the presence of the bug from the user instead of pointing his attention to it.

This comment has been minimized.

Copy link
@jglick

jglick Oct 1, 2015

Author Member

there should be no version specified (presuming it does not depend on any recent features)

It does not depend on any recent features. But if you do not specify a version, then the test will not test the version on the update center, currently 2.12. Instead it will use the 2.7.1 or whatever bundled¹ with jenkins.war. This was the way I found to force it to install version 2.12 or newer so that the test is meaningful.

¹One of the many irritating consequences of plugin bundling—hope to see it die soon.

This comment has been minimized.

Copy link
@olivergondza

olivergondza Oct 2, 2015

Member

Makes sense then, we should remove once we get rid of bundled plugins.

@stephenc

This comment has been minimized.

Copy link
Member

commented Oct 2, 2015

🐝

@jglick

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2015

Now passes with 2.12.1 on the update center.

jglick added a commit that referenced this pull request Oct 2, 2015

Merge pull request #41 from jglick/IllegalAccessError-JENKINS-22252
[JENKINS-22252] Reproduced problem in test

@jglick jglick merged commit aac7425 into jenkinsci:master Oct 2, 2015

@jglick jglick deleted the jglick:IllegalAccessError-JENKINS-22252 branch Oct 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.