[JENKINS-22252] Reproduced problem in test #41
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -246,4 +248,20 @@ private void assertHasModule(MavenModuleSet job, String name) { | |||
| find(by.xpath("//a[@href='%s/']", name)).click(); | |||
| assertThat(driver.getCurrentUrl(), equalTo(build.module(name).url.toExternalForm())); | |||
| } | |||
|
|
|||
| @Issue("JENKINS-22252") | |||
| @WithPlugins({"maven-plugin@2.12", "tasks"}) | |||
There was a problem hiding this comment.
Is the plugin version specified for some reason? If the plugin version is fixed here, then this test is not going to catch possible regressions in future versions.
There was a problem hiding this comment.
Ok. This is actually reproducing the error exactly in this version. Nevermind.
There was a problem hiding this comment.
Well, reading the code again... I think my initial question still makes sense 😄
There was a problem hiding this comment.
I suppose this version specification is a temporary thing and @jglick is going to update it to 2.13 after the release. Before that this test will be failing.
There was a problem hiding this comment.
Shouldn't this be the initial version required to get the test running? I.e., 2.12-SNAPSHOT or 2.13? It is not required to change it when 2.13 has been released. So we can better see in which version the fix has been applied.
There was a problem hiding this comment.
It should be the first version where necessary features was introduced. As it is a regression introduced in 2.12 IIUC, there should be no version specified (presuming it does not depend on any recent features).
As a rule of thumb, consider someone is running this against a plugin version with JENKINS-22252 present. If we declare this should run with first fixed version we effectively hide the presence of the bug from the user instead of pointing his attention to it.
There was a problem hiding this comment.
there should be no version specified (presuming it does not depend on any recent features)
It does not depend on any recent features. But if you do not specify a version, then the test will not test the version on the update center, currently 2.12. Instead it will use the 2.7.1 or whatever bundled¹ with jenkins.war. This was the way I found to force it to install version 2.12 or newer so that the test is meaningful.
¹One of the many irritating consequences of plugin bundling—hope to see it die soon.
There was a problem hiding this comment.
Makes sense then, we should remove once we get rid of bundled plugins.
|
🐝 |
|
Now passes with 2.12.1 on the update center. |
[JENKINS-22252] Reproduced problem in test
JENKINS-22252
@reviewbybees