Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Case insensitive match of overrides #82

Merged
merged 3 commits into from
Mar 5, 2019

Conversation

paba19
Copy link

@paba19 paba19 commented Feb 27, 2019

This is a quick fix to allow overrides in declarative mode for some mixed-case parameters (such as inheritFrom).

Changes:

  • removed toLowerCase() in isAllowedOverride method

Tests:

  • tried to specify not allowed parameter: failed as expected
  • specified only allowed included mixed-case ones: worked as expected

@pgarbe
Copy link
Contributor

pgarbe commented Mar 4, 2019

Good catch. Maybe it makes sense to move the toLowerCase() into the isAllowedOverride method?

return allowedOverridesList.contains(override);

@paba19
Copy link
Author

paba19 commented Mar 5, 2019

That is a very good point actually.

Changed it as suggested.

@pgarbe pgarbe merged commit 5e0f5e7 into jenkinsci:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants