Add configurability and JIRA version creation/release #10
Conversation
Added ability to release existing versions on JIRA. Made the server, channel and nickname configurable via properties
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| this.unknownCommands = unknownCommands; | ||
| } | ||
|
|
||
| @Override | ||
| protected void onMessage(String channel, String sender, String login, String hostname, String message) { | ||
| if (!channel.equals("#jenkins")) return; // not in this channel | ||
| protected void onMessage(String chan, String sender, String login, String hostname, String message) { |
There was a problem hiding this comment.
Is there any need to rename channel to chan? It prevents conflicts with class fields, but it causes many changes unrelated to the PR
There was a problem hiding this comment.
It could be swapped so that the class field was chan and the parameter was channel. I can do it if you want me to make that change.
|
I think it was decided to not go with my proposal for versions, so I am closing this out. |
|
I suppose that @kohsuke should make a decisions about the PR. |
Added a bit of configurability to make it easier to test the bot on a different network or in a different channel. Also added two methods for working with versions on JIRA. createVersion allows a valid user to create a version in JIRA, releaseVersion allows a valid user to mark an existing version as released.