Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working with Nicu on css loading + JSX render coordination #1069

Closed
wants to merge 7 commits into from
Closed

Working with Nicu on css loading + JSX render coordination #1069

wants to merge 7 commits into from

Conversation

tfennelly
Copy link
Member

@tfennelly tfennelly commented May 16, 2017 •
edited by michaelneale
Loading

tfennelly
tfennelly commented May 16, 2017
View reviewed changes
js-extensions/src/ResourceLoadTracker.js
linkEl.onload = onload;
} else {
onload();
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicuPascu I just added the above check on linkEl. That code is not in the version o js-extensions that we published.

tfennelly
tfennelly commented May 16, 2017
View reviewed changes
js-extensions/src/ExtensionRenderer.jsx
this._renderAllExtensions();
ExtensionRenderer.resourceLoadTracker.onMount(this.props.extensionPoint, function() {
this._renderAllExtensions();
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now, we only call this._renderAllExtensions() after all CSS has ben loaded.

@cliffmeyers
Copy link
Contributor

Hi, I have two questions about this:

  • I recall seeing a similar "re-render flash" when I would open the /organizations/jenkins/create-pipeline screen directly. Some of the content in this page renders via an extension point, so I expect it was rendering before its child CSS was loaded. @NicuPascu perhaps you could check that page too as part of this fix?
  • I noticed that @scherler was working on a bug that involved translations sometimes not loading before initial page render. Could that be related to this same kind of problem?

@tfennelly
Copy link
Member Author

@cliffmeyers

I noticed that @scherler was working on a bug that involved translations sometimes not loading before initial page render. Could that be related to this same kind of problem?

I don't know what that is but I doubt it's related.

@michaelneale
Copy link
Member

closing this as a bit old now. It will live on in our hearts and git history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfennelly @cliffmeyers @michaelneale