Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-50406 "Triggered Build" links broken with cloudbees-folder #1699

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

sophistifunk
Copy link
Collaborator

Fix the issue with downstream build URL generation, and add some snarky FIXMEs which I will address in a seperate PR

Description

See JENKINS-50406.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

…ownstream build URL generation, and add some snarky FIXMEs which I will address in a seperate PR
@sophistifunk
Copy link
Collaborator Author

I will address the new FIXMEs in a separate PR tomorrow, as it will need to be done carefully in order not to mess with Thor and co, and will take a few hours.

Copy link
Collaborator

@NicuPascu NicuPascu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to having all url utils in one place

@sophistifunk sophistifunk merged commit d508e97 into master Mar 27, 2018
@sophistifunk sophistifunk deleted the bug/JENKINS-50406-link-to-downstream-in-folder branch March 27, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants