Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade workflow log api #1833

Merged
merged 6 commits into from
Oct 16, 2018
Merged

Upgrade workflow log api #1833

merged 6 commits into from
Oct 16, 2018

Conversation

vivek
Copy link
Collaborator

@vivek vivek commented Oct 12, 2018

Description

See JENKINS-XXXXX.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

jglick and others added 3 commits October 12, 2018 11:19
@jglick @vivek
Fixing waitForMessage in AbstractRunImplTest.queuedAndRunningParallel (…
5da8147 
…#1830)

* Updated beta versions of workflow plugins for testing

* Adjusted test to changed message format of the node

* Fixing waitForMessage to wait for something more reliable and pertinent.
@vivek
Update workflow plugins with logging changes
9b2bd66
@vivek
pipeline plugins upgrade
20f7e9f
@vivek vivek requested review from olamy and dwnusbaum October 12, 2018 19:16
dwnusbaum
dwnusbaum reviewed Oct 12, 2018
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
dwnusbaum
dwnusbaum reviewed Oct 12, 2018
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@vivek vivek requested a review from kshultzCB October 12, 2018 19:40
kshultzCB
kshultzCB approved these changes Oct 15, 2018
View reviewed changes
Copy link
Collaborator

@kshultzCB kshultzCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending a green run on CI. If we see some of the usual suspects fail, we'll recognize them and that'll be okay.

Nice changes to make those couple of tests less brittle. 👍

olamy
olamy approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivek vivek merged commit 5d506b2 into master Oct 16, 2018
@halkeye halkeye deleted the upgrade-workflow-log-api branch January 24, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum left review comments

@olamy olamy olamy approved these changes

@kshultzCB kshultzCB kshultzCB approved these changes

@d3rp3tt3 d3rp3tt3 Awaiting requested review from d3rp3tt3

@kzantow kzantow Awaiting requested review from kzantow

@michaelneale michaelneale Awaiting requested review from michaelneale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivek @olamy @dwnusbaum @kshultzCB @jglick