Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-52825] - Add blueocean-executor-info-plugin to the blueocean meta package as a dependancy #1925

Merged
merged 2 commits into from
Mar 19, 2019
Merged

[JENKINS-52825] - Add blueocean-executor-info-plugin to the blueocean meta package as a dependancy #1925

merged 2 commits into from
Mar 19, 2019

Conversation

halkeye
Copy link
Member

@halkeye halkeye commented Mar 4, 2019 •
edited
Loading

Description

See JENKINS-52825.

As per craig on gitter, new plugin should be installed by default.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

NicuPascu
NicuPascu approved these changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@NicuPascu NicuPascu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐝

Gavin Mogan added 2 commits March 6, 2019 16:39
@halkeye halkeye force-pushed the feat/JENKINS-52825/add-plugin-to-meta branch from 38acf88 to aa9b457 Compare March 7, 2019 00:39
@sophistifunk sophistifunk merged commit e2dd04d into master Mar 19, 2019
@sophistifunk sophistifunk deleted the feat/JENKINS-52825/add-plugin-to-meta branch March 19, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicuPascu NicuPascu NicuPascu approved these changes

@d3rp3tt3 d3rp3tt3 Awaiting requested review from d3rp3tt3

@kzantow kzantow Awaiting requested review from kzantow

@olamy olamy Awaiting requested review from olamy

@vivek vivek Awaiting requested review from vivek

@sophistifunk sophistifunk Awaiting requested review from sophistifunk

@imeredith imeredith Awaiting requested review from imeredith

@scherler scherler Awaiting requested review from scherler

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halkeye @NicuPascu @sophistifunk