Upgrade some dependencies #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Jul 31, 2023
| @@ -37,7 +37,7 @@ | |||
| <groupId>org.eclipse.jgit</groupId> | |||
| <artifactId>org.eclipse.jgit.ssh.jsch</artifactId> | |||
| <!-- TODO this is hard to manage; if needed, should be in BOM --> | |||
| <version>6.5.0.202303070854-r</version> | |||
| <version>6.6.0.202305301015-r</version> | |||
There was a problem hiding this comment.
Aligned with the version shipped in the version of the Git plugin shipped in BOM 2278.v47b_4508e256a (consumed below).
| @@ -66,6 +66,7 @@ | |||
| <dependency> | |||
| <groupId>org.jvnet.hudson.plugins</groupId> | |||
| <artifactId>favorite</artifactId> | |||
| <version>2.4.2</version> | |||
There was a problem hiding this comment.
Latest available version at the time of this writing.
| @@ -232,7 +232,7 @@ | |||
| <dependency> | |||
| <groupId>io.jenkins.tools.bom</groupId> | |||
| <artifactId>bom-2.401.x</artifactId> | |||
| <version>2102.v854b_fec19c92</version> | |||
| <version>2278.v47b_4508e256a</version> | |||
There was a problem hiding this comment.
Latest available version at the time of this writing.
Comment on lines
-475
to
-498
| <dependency> | ||
| <groupId>org.jvnet.hudson.plugins</groupId> | ||
| <artifactId>favorite</artifactId> | ||
| <version>2.3.1</version> | ||
| <exclusions> | ||
| <!-- Upper bound fix: Remove it once token-micro plugin is fixed to remove dependency on asm-tree | ||
| PR https://github.com/jenkinsci/token-macro-plugin/pull/31. Fix to be available in 2.4.0. | ||
| --> | ||
| <exclusion> | ||
| <groupId>org.ow2.asm</groupId> | ||
| <artifactId>asm</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.ow2.asm</groupId> | ||
| <artifactId>asm-tree</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
There was a problem hiding this comment.
No need to pin such an old version in the dependency management section. The linked PR is five years old.
Comment on lines
-525
to
-522
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>ant</artifactId> | ||
| <version>1.11</version> | ||
| </dependency> |
There was a problem hiding this comment.
No need to pin such an old version in the dependency management section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.