Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-38300] Fix pull requests within an org folder #510

Merged
merged 1 commit into from Sep 20, 2016
Merged

[FIX JENKINS-38300] Fix pull requests within an org folder #510

merged 1 commit into from Sep 20, 2016

Conversation

kzantow
Copy link
Collaborator

@kzantow kzantow commented Sep 19, 2016

Description

Create a GH org with pull requests, click to open the latest run for a pull request. You can use kzantow as the org, then filter repositories to failure-project.

See JENKINS-38300.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@jenkinsci/code-reviewers @reviewbybees

@ghost
Copy link

ghost commented Sep 19, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@i386
Copy link
Contributor

i386 commented Sep 20, 2016

Does this add showing the full path too? There's another similar ticket on the backlog I think

@kzantow
Copy link
Collaborator Author

kzantow commented Sep 20, 2016

@i386 yes, it causes the full path to show which was the crux of the issue

@michaelneale
Copy link
Member

🐝

nice work. Yes works as advertised.

The name is correct too (it is still wrong in the activity screen, but unrelated to this PR)

Copy link
Member

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I APPROVE OF THIS PULL REQUEST

@kzantow kzantow merged commit 83b81b6 into jenkinsci:master Sep 20, 2016
@kzantow kzantow deleted the JENKINS-38300-pr-in-org-fail branch September 20, 2016 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants