Bug/jenkins 37425 run stop toast changes #515

cliffmeyers · 2016-09-21T20:38:05Z

Description

See JENKINS-37425.
This PR updates the Favorite cards to use the same exactly component as the rest of dashboard for start, stop and replay of builds.

Submitter checklist

Link to JIRA ticket in description, if appropriate.
Change is code complete and matches issue description
Appropriate unit or acceptance tests or explanation to why this change has no tests
Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
Ran Acceptance Test Harness against PR changes.

Reviewer checklist

Run the changes and verified the change matches the issue description
- Test the Run, Stop and Replay buttons in the Favorite cards.
- Ensure the "OPEN" link in the Toast still works.
Reviewed the code
Verified that the appropriate tests have been written or valid explanation given

@jenkinsci/code-reviewers @reviewbybees

…L to the corresponding UI URL, to avoid encoding bugs

…s; add some assets for testing and in prep of "Run Pipeline" refactor

…iple "libraries" (e.g. JDL and CoreJS) in the src/main/webapp/assets directory

… publish)

… be shared across plugins; support multiple subscriptions; still needs testing

…d to be caused by two SSE connections being made using the same clientId

…lueocean-core-js

… style collisions with button tag

…st messaging

…plicate listener for each subscription added

…and "stopped" toasts

…prevents them from being added; in place until we find a more elegant fix in upstream code

…ithin ToastService (for now)

…ity tab

…o it can toggle or show only run or stop; update Activity tab to use new RunButton at top for non multi-branch

# Conflicts: # blueocean-core-js/package.json # blueocean-core-js/src/js/components/ReplayButton.jsx # blueocean-core-js/src/js/components/RunButton.jsx # blueocean-dashboard/package.json # blueocean-personalization/package.json # blueocean-web/package.json

…w handled directly by RunButton / ReplayButton; delint

…od; fix a bug on Run Details where replaying multiple times would not work because the button was not having its state reset when bound to a new Run

…ardCards down into PipelineCard - where it's more sensible to be; update all shrinkwraps

# Conflicts: # blueocean-dashboard/npm-shrinkwrap.json # blueocean-personalization/npm-shrinkwrap.json # blueocean-web/npm-shrinkwrap.json

cliffmeyers · 2016-09-26T19:04:29Z

blueocean-personalization/src/main/js/components/DashboardCards.jsx

@@ -7,34 +7,14 @@ import { connect } from 'react-redux';
 import { createSelector } from 'reselect';


Pushed a lot of logic from this component down into PipelineCard. Instead of this component picking out the data and passing a ton of props down into the card, it made sense to just pass the object down and let PipelineCard do that work.

cliffmeyers · 2016-09-26T19:04:52Z

blueocean-personalization/src/main/js/components/DashboardCards.jsx

-            text: `Stopping "${name}" #${runId}...`,
-        });
-    }
-


The Run/ReplayButton components do all the work of run, stop and replay... so this code can go.

cliffmeyers · 2016-09-26T19:06:08Z

blueocean-personalization/src/main/js/components/DashboardCards.jsx

+                    >
+                        {favoriteCards}
+                    </TransitionGroup>
+                </div>
            </FavoritesProvider>
        );


Now that this component is just rendering a stack of cards the render method is a lot simpler.

cliffmeyers · 2016-09-26T19:06:47Z

blueocean-personalization/src/main/js/redux/FavoritesActions.jsx

-            Fetch.fetch(stopPipelineUrl, fetchOptions);
-        };
-    },
-
    updateRun(jobRun) {


All this is handled by Run/ReplayButton now.

cliffmeyers · 2016-09-26T19:08:34Z

blueocean-core-js/src/less/run-button.less

+
+            .svg-icon-inner {
+                fill: #CCC;
+            }


Adding some hover states for the start / stop / replay icons.

cliffmeyers · 2016-09-26T19:09:01Z

blueocean-core-js/src/less/run-button.less

-                    background-image: url('./icons/stop-button-blue-dark.svg');
-                }
-            }
+            /* asset has different padding than material-icon asset used in .run-button: nudge it slightly */


Stop button now uses a SVG inline to again avoid the need for 4 different external SVG assets. The SVG is tiny, so it shouldn't be bad at all.

cliffmeyers · 2016-09-26T19:10:30Z

blueocean-core-js/src/js/components/RunButton.jsx

-        toastService.newToast({
-            text: `Queued "${name}"`,
-        });
+        runApi.startRun(this.props.runnable)


Probably the most significant change above: since we create "Started" and "Stopping" toasts immediately when the REST API call returns, we don't need to listen to SSE to create these toasts. The old code was a lot more complex than it needed to be.

cliffmeyers · 2016-09-26T19:11:16Z

blueocean-core-js/src/js/components/ReplayButton.jsx

+            });
+        }
+    }
+


This fixes a bug where the button got stuck in replaying state if going through the start -> stop -> rerun cycle more than once.

cliffmeyers · 2016-09-26T19:12:14Z

blueocean-core-js/src/js/capability/Capable.js

+
+        const shortNameMatches = flattenedCapabilities.filter(longName => shortNames.indexOf(longName) !== -1);
+        if (shortNameMatches.length > 0) {
+            return true;
        }


Easy for someone to pass an array as the first argument rather than spreading it, so this logic handles either case (and has associated tests).

ghost · 2016-09-26T19:19:01Z

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

cliffmeyers · 2016-09-26T19:33:58Z

Passed ATH locally. 2016-09-26 15:33:10,427 [Thread-3] INFO (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - OK. 292 total assertions passed. (5m 10s)
`

michaelneale · 2016-09-27T06:26:40Z

blueocean-dashboard/src/main/js/components/RunDetails.jsx

-                                  autoNavigate
-                                />
-                            </IfCapability>
+                            <ReplayButton


I did a quick chance of anon read only access - seems ok (from what I can tell)

michaelneale · 2016-09-27T06:30:20Z

That's a lot of code to review - so so not sure if my read of it counts, but it seems sensible (lots of removed messy code, which seems nice) and seems to work.

I assume you ran the latest ATH - after doing a clean -DcleanNode? (I also kicked off: https://ci.blueocean.io/job/ATH-Jenkinsfile/job/master/6/ on CI - just to be sure).

This gets a 🐝 from me, but I would like @sophistifunk or @scherler to take a look if they are around if possible.

(also using -beta dependency that needs to change, may need updating to master as a few other changes went in, yada yada YMMV)

sophistifunk · 2016-09-27T07:42:04Z

Code looks OK to me 🐝

# Conflicts: # blueocean-dashboard/src/main/js/components/RunDetails.jsx

cliffmeyers · 2016-09-27T16:03:52Z

ATH passed locally. 2016-09-27 12:02:35,585 [Thread-3] INFO (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - OK. 316 total assertions passed. (4m 3s)

Cliff Meyers added 30 commits August 25, 2016 21:14

[JENKINS-36687] build a utility function that converts a Run's HAL UR…

3cf8976

…L to the corresponding UI URL, to avoid encoding bugs

[JENKINS-36687] comments

7f59cb1

[JENKINS-36687] add support for styles and assets in blueocean-core-j…

46e8164

…s; add some assets for testing and in prep of "Run Pipeline" refactor

[JENKINS-36687] rework the blueocean-web build so it can support mult…

fefd08f

…iple "libraries" (e.g. JDL and CoreJS) in the src/main/webapp/assets directory

[JENKINS-36687] amend .gitignore

94caf5d

[JENKINS-36687] UrlBuilder: more tests, better errors

6ede71b

[JENKINS-36687] typos ;)

50735ec

[JENKINS-36687] fix blueocean-core-js versions in package.json (after…

3798970

… publish)

[JENKINS-36687] formatting

56b63ea

[JENKINS-36687] begin migrating SseBus to blueocean-core-js so it can…

b4d8d6b

… be shared across plugins; support multiple subscriptions; still needs testing

[JENKINS-36687] clean up new SseBus code; fix some issues that appear…

ebf7f8e

…d to be caused by two SSE connections being made using the same clientId

[JENKINS-36687] switch blueocean-personalization to use SseBus from b…

5bd98e1

…lueocean-core-js

[JENKINS-36687] new "RunButton" work in progress

fa35e04

[JENKINS-36687] style button as a tag rather than button to avoid JDL…

d2e6218

… style collisions with button tag

[JENKINS-36687] stop button state; refinement of styling and positioning

4e73c6d

[JENKINS-36687] create API utility to encapsulate fetch logic

e8dfd3a

[JENKINS-36687] wire up start / stop API to the RunButton; refine toa…

d1e84fc

…st messaging

[JENKINS-36687] fix some broken logic in SSE bus that was adding a du…

ece85ee

…plicate listener for each subscription added

[JENKINS-36687] simplify listener logic; wire up logic for "started" …

d903cfe

…and "stopped" toasts

[JENKINS-36687] brute force fix for "duplicate toasts" bug that just …

4511d99

…prevents them from being added; in place until we find a more elegant fix in upstream code

[JENKINS-36687] strip out "awaiting job event" code in favor of fix w…

a5468a4

…ithin ToastService (for now)

[JENKINS-36687] implement "stopping" state for RunButton

6595c55

[JENKINS-36687] customize label of Run button

7737b1e

[JENKINS-36687] minor refinements to labels

d05201b

[JENKINS-35796] add the "Stop" button to the Run Details screen

f7e7e7a

[JENKINS-36687] fix regression in ToastService spec

431f026

tick version after publishing 0.0.3-beta4; update deps

f612725

[JENKINS-36974] add the "stop" button for running builds to the Activ…

d5cb842

…ity tab

[JENKINS-36974] enhance RunButton to support multiple "buttonTypes" s…

f3d86ec

…o it can toggle or show only run or stop; update Activity tab to use new RunButton at top for non multi-branch

[JENKINS-36974] stop button hover state

112c3b1

Cliff Meyers added 8 commits September 22, 2016 11:14

[JENKINS-37425] delint; fix broken tests

efedc36

[JENKINS-37425] remove redundant code from personalization that is no…

86d594a

…w handled directly by RunButton / ReplayButton; delint

[JENKINS-37425] simplify logic in render method to "isRunFailed" meth…

e088389

…od; fix a bug on Run Details where replaying multiple times would not work because the button was not having its state reset when bound to a new Run

tick up versions after publish blueocean-core-js 0.0.17-beta5

c5f5292

Merge branch 'master' into bug/JENKINS-37425-run-stop-toast-changes

536c45a

[JENKINS-37425] refactor display logic for favorite cards from Dashbo…

3dc17df

…ardCards down into PipelineCard - where it's more sensible to be; update all shrinkwraps

Merge branch 'master' into bug/JENKINS-37425-run-stop-toast-changes

33a1f95

# Conflicts: # blueocean-dashboard/npm-shrinkwrap.json # blueocean-personalization/npm-shrinkwrap.json # blueocean-web/npm-shrinkwrap.json

cliffmeyers commented Sep 26, 2016

View reviewed changes

cliffmeyers added needs-review and removed work-in-progress labels Sep 26, 2016

michaelneale reviewed Sep 27, 2016

View reviewed changes

Cliff Meyers added 3 commits September 27, 2016 10:02

Merge branch 'master' into bug/JENKINS-37425-run-stop-toast-changes

1bed421

# Conflicts: # blueocean-dashboard/src/main/js/components/RunDetails.jsx

[JENKINS-37425] delint

62b9466

tick up versions after publish blueocean-core-js 0.0.18

65bff30

cliffmeyers merged commit ca8ec53 into master Sep 27, 2016

cliffmeyers deleted the bug/JENKINS-37425-run-stop-toast-changes branch September 27, 2016 16:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug/jenkins 37425 run stop toast changes #515

Bug/jenkins 37425 run stop toast changes #515

cliffmeyers commented Sep 21, 2016 •

edited by michaelneale

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

cliffmeyers Sep 26, 2016

ghost commented Sep 26, 2016

cliffmeyers commented Sep 26, 2016

michaelneale Sep 27, 2016

michaelneale commented Sep 27, 2016 •

edited

sophistifunk commented Sep 27, 2016

cliffmeyers commented Sep 27, 2016 •

edited

		@@ -7,34 +7,14 @@ import { connect } from 'react-redux';
		import { createSelector } from 'reselect';

Bug/jenkins 37425 run stop toast changes #515

Bug/jenkins 37425 run stop toast changes #515

Conversation

cliffmeyers commented Sep 21, 2016 • edited by michaelneale

Description

Submitter checklist

Reviewer checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Sep 26, 2016

cliffmeyers commented Sep 26, 2016

Choose a reason for hiding this comment

michaelneale commented Sep 27, 2016 • edited

sophistifunk commented Sep 27, 2016

cliffmeyers commented Sep 27, 2016 • edited

cliffmeyers commented Sep 21, 2016 •

edited by michaelneale

michaelneale commented Sep 27, 2016 •

edited

cliffmeyers commented Sep 27, 2016 •

edited