Feature/jenkins 38598 create pipeline from GitHub #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry for new "Creation" submodule
…il component is ready; integrate with existing router / background code so the existing screen's DOM will display under the dialog
…of create-pipeline
…orce reloaded / re-rendered
…list and workflow steps in Create Pipeline
…out new MultiStepFlow / FlowStep APIs
…nst NPE in config
… XP; lay the groundwork for "re-entrant" flow; still needs to sandbox rendered content
…ender) so that we can have more flexibility with how we render untrusted React code
…the extension points in Create Pipeline flow
…ync w/ props.children and yielding incorrect statuses for steps; now we just track the current step index which is much simpler anyways
…eeds sharing between the two steps; enhance "CompletedStep" to display its progress via percent complete
…inate duplicate ContextBridge; update deps after beta publish
Eventually it should be moved out in it's own repo
added 9 commits
January 31, 2017 14:14
…s for org folder detection and configuration
…, error state, added button to navigate back to Dashboard
…-github # Conflicts: # blueocean-core-js/npm-shrinkwrap.json # blueocean-core-js/package.json # blueocean-dashboard/npm-shrinkwrap.json # blueocean-dashboard/package.json # blueocean-personalization/npm-shrinkwrap.json # blueocean-personalization/package.json # blueocean-web/npm-shrinkwrap.json # blueocean-web/package.json
|
I am going to start testing |
added 2 commits
February 7, 2017 10:05
…-github # Conflicts: # blueocean-dashboard/npm-shrinkwrap.json # blueocean-dashboard/package.json # blueocean-personalization/npm-shrinkwrap.json # blueocean-personalization/package.json # blueocean-web/npm-shrinkwrap.json # blueocean-web/package.json
|
Looking good - put feedback in the doc |
added 11 commits
February 8, 2017 10:29
…repo" to "auto discover"
…ayed for orgs not yet created
…timeout after successful save
…k unless show() was called first - even though the indicator is still visible by default
…ith current state of master
… "requestedRepos")
…-github # Conflicts: # blueocean-dashboard/npm-shrinkwrap.json # blueocean-dashboard/package.json # blueocean-personalization/npm-shrinkwrap.json # blueocean-personalization/package.json # blueocean-web/npm-shrinkwrap.json # blueocean-web/package.json
|
Tried latest "mocked" version - LGTM. One small :nit: was that when it was busy creating, it didn't disable the git/github buttons right at the top is all but I think can proceed. |
…-github # Conflicts: # blueocean-dashboard/npm-shrinkwrap.json # blueocean-dashboard/package.json # blueocean-personalization/npm-shrinkwrap.json # blueocean-personalization/package.json # blueocean-web/npm-shrinkwrap.json # blueocean-web/package.json
|
Closing in favor of #812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Submitter checklist
Reviewer checklist
@reviewbybees