[JENKINS-33309] Use ChangeRequestAction #29
Conversation
Also make sure SCMHead.actions are exported to REST.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| // Note: not using Branch.name, since in the future that could be something different | ||
| // than SCMHead.name, which is what we really want here. | ||
| envs.put("BRANCH_NAME", projectFactory.getBranch(j).getHead().getName()); | ||
| envs.put("BRANCH_NAME", head.getName()); | ||
| ChangeRequestAction cr = head.getAction(ChangeRequestAction.class); |
There was a problem hiding this comment.
Who is adding this action to head?
There was a problem hiding this comment.
IOW where is the TransientActionFactory implementation (as per jenkinsci/scm-api-plugin#7)?
There was a problem hiding this comment.
The current implementation is in github-branch-source (see linked PR) and uses an override rather than TransientActionFactory.
There was a problem hiding this comment.
Ok. So there are currently two ways to add actions to an SCMHead: extend it and override getAllActions or add an implementation of TransientActionFactory, right?
There was a problem hiding this comment.
Correct. Similar to the situation for Actionables, where you can override getActions, etc., from the inside; or use TransientActionFactory from the outside. Actionable also exposes addAction from the outside, though this presumes that there is mutable persisted action storage, an imposition I did not really want to apply to SCMHead (besides the other API problems with Actionable mentioned in a linked JIRA ticket).
|
🐝 |
|
@reviewbybees done (@stephenc merge if you agree) |
[JENKINS-33309] Use ChangeRequestAction
Downstream of jenkinsci/scm-api-plugin#7.
Can use cloudbeers/PR-demo#9 as a demo.
@reviewbybees