[JENKINS-39520] ExtensionList.removeAll is unimplemented #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
stephenc
reviewed
Nov 4, 2016
| @@ -150,7 +150,9 @@ private static void doAddSpecificDescriptors() { | |||
| } | |||
| } | |||
| LOGGER.log(Level.FINE, "clearing {0}", old); | |||
| all().removeAll(old); | |||
| for (CustomOrganizationFolderDescriptor d : old) { | |||
| all().remove(d); | |||
There was a problem hiding this comment.
🐛 can you show that this will not cause an infinite loop of death as you are now calling https://github.com/jenkinsci/jenkins/blob/6718a71f4be8cda7c575ae40ea0befec5c2ff1cf/core/src/main/java/hudson/ExtensionList.java#L197-L205
There was a problem hiding this comment.
Yes but on a different extension list.
jglick
added a commit
that referenced
this pull request
Nov 4, 2016
…INS-39520 [JENKINS-39520] ExtensionList.removeAll is unimplemented (cherry picked from commit f5c8342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-39520
@reviewbybees