Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int 198 run jobs with jop without defining thresholds #67

Merged

Conversation

bryanateoan
Copy link
Contributor

@bryanateoan bryanateoan commented Sep 8, 2020

Purpose

Allow jobs with application who's thresholds are overridden by a job outcome policy to run without having to define a local or global thresholds first. This way the user can start using the plugin in minimal configuration.

Steps to reproduce

  1. Go to manage settings and delete all thresholds.
  2. Run a job with an application that has an applicable job outcome policy
  3. Run the job.

Expected

  1. Jobs with applications that have applicable job outcome policies will run as expected.
  2. Jobs with applications that do not have applicable job outcome policies will fail with warning that there are no thresholds defined.

Other

  • Removed the queryBy filter warnings for applications with job outcome policies since it is going to be overridden by the job outcome policy
  • Added a description for when applications with job outcome policies are checked so that it is easier to read the log output when multiple applications are configured for the same job

@bryanateoan bryanateoan merged commit 0503976 into master Sep 10, 2020
@bryanateoan bryanateoan deleted the INT-198-run-jobs-with-jop-without-defining-thresholds branch January 19, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants