-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-33577] Demonstration test #80
[JENKINS-33577] Demonstration test #80
Conversation
…py artifacts from a build downstream of a Pipeline build.
@@ -22,7 +22,7 @@ | |||
</licenses> | |||
|
|||
<properties> | |||
<workflow.version>1.1</workflow.version> | |||
<workflow.version>1.4.2</workflow.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build
did not return an appropriate value in the ancient 1.1 release. 1.4.2 is the newest compatible with 1.580.x.
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
@@ -24,7 +24,7 @@ | |||
<properties> | |||
<jenkins.version>1.580.1</jenkins.version> | |||
<java.level>6</java.level> | |||
<workflow.version>1.1</workflow.version> | |||
<workflow.version>1.4.2</workflow.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build
did not return an appropriate value in the ancient 1.1 release. 1.4.2 is the newest compatible with 1.580.x.
@ikedam, @apemberton ping |
@jglick But I don't think this change needs to be merged as this doesn't provide any fixes or new features of copyartifact, but contains changes for dependencies that isn't important for copyartifact itself. Do you mean upgrading copyartifact-plugin should force also to upgrade pipeline-plugin? |
Well 1.4.2 is a rather old version. Anyway this is only |
You're absolutely right. I think this is ready to merge. |
JENKINS-33577
@reviewbybees esp. @apemberton