Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-26345] "CVS Symbolic Name parameter" not working any more #43

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

fredg02
Copy link
Member

@fredg02 fredg02 commented Jun 9, 2016

JENKINS-26345

This fix is inspired by this commit: kohsuke/Hudson-GIT-plugin@f92bb2f

Please let me know if it can be improved.

@tmclnk
Copy link

tmclnk commented Jan 12, 2017

Have you gotten any response on this? If not, it might be worth it to sign the agreements for commit access and try to get it in.

@fredg02
Copy link
Member Author

fredg02 commented Apr 11, 2017

@kohsuke or @jglick: Is it OK If I merge this PR? It has been running in production for 10 months successfully.

@fredg02
Copy link
Member Author

fredg02 commented Apr 18, 2017

It's been a week without a reply. Since this is basically a copy-and-paste of a fix that @kohsuke did and it's battle tested in production I consider the risk to be quite low. Therefore I'm merging this.

@fredg02 fredg02 merged commit 25e0d5f into jenkinsci:master Apr 18, 2017
@jglick jglick requested a review from mc1arke February 28, 2018 21:09
@jglick
Copy link
Member

jglick commented Feb 28, 2018

@mc1arke FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants