fix(Windows): remove duplication in tags

[lemeurherve]

This PR fixes #546 by including the remoting and build number tag by default, as we're always publishing tags the same way, with -PushVersion (will be the subject of a follow-up PR).

Testing done

Validation of the fix by comparing the outputs of the following command:

DOCKERHUB_ORGANISATION="jenkins4eval" IMAGE_TYPE="nanoserver-ltsc2022" && \
pwsh build.ps1 -PushVersion -RemotingVersion 3186.vc3b_7249b_87eb_ -BuildNumber 1 -DisableEnvProps publish -DryRun

Before (output lines deduplicated)

= BUILD: Building all images...
 (dry-run) docker-compose --file=build-windows.yaml build --parallel --pull
 = BUILD: Finished building all image
 = PUBLISH: (dry-run) docker tag then publish 'jdk21-nanoserver-ltsc2022 jenkins4eval/agent:jdk21-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk21-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-jdk21-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk21-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-3186.vc3b_7249b_87eb_-1-jdk21-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk11-nanoserver-ltsc2022 jenkins4eval/agent:jdk11-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk11-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-jdk11-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk11-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-3186.vc3b_7249b_87eb_-1-jdk11-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:jdk17-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-jdk17-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-3186.vc3b_7249b_87eb_-1-jdk17-nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:nanoserver-ltsc2022'
 = PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-nanoserver-ltsc2022'
 Build finished successfully

After

= BUILD: Building all images...
(dry-run) docker-compose --file=build-windows.yaml build --parallel --pull
= BUILD: Finished building all images
= PUBLISH: (dry-run) docker tag then publish 'jdk21-nanoserver-ltsc2022 jenkins4eval/agent:jdk21-nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk21-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-jdk21-nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk11-nanoserver-ltsc2022 jenkins4eval/agent:jdk11-nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk11-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-jdk11-nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:jdk17-nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-jdk17-nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:nanoserver-ltsc2022'
= PUBLISH: (dry-run) docker tag then publish 'jdk17-nanoserver-ltsc2022 jenkins4eval/agent:3186.vc3b_7249b_87eb_-1-nanoserver-ltsc2022'
Build finished successfully

No more duplicated remoting & build number in tags.

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[dduportal]

Nice catch, and very good work, many thanks!