Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(Windows): remove obsolete Build build.ps1 script argument #549

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Oct 26, 2023

This PR is the follow-up of #547 and #548, removing the Build argument which was used before the integration of the docker-compose file for Windows.

Changes without the cherry-pick of #548 to review: 75b5a4c

Note: this PR can be the one to be merged to include all at once the build.ps1 script cleanup, the tags fix and the dry-mode.

EDIT: supersedes and closes #548

Testing done

Ran the following command before and after:

DOCKERHUB_ORGANISATION="jenkins4eval" IMAGE_TYPE="nanoserver-ltsc2022" && \
pwsh build.ps1 -RemotingVersion 3186.vc3b_7249b_87eb_ -BuildNumber 1 -DisableEnvProps publish -DryRun

The outputs remain the same.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@lemeurherve lemeurherve requested a review from a team as a code owner October 26, 2023 17:34
@lemeurherve lemeurherve marked this pull request as draft October 26, 2023 17:35
@lemeurherve
Copy link
Member Author

This PR can be merged as it is instead of merging first #548 then this one.

@dduportal dduportal merged commit 3481758 into jenkinsci:master Nov 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants