Simpler and more flexible to use changeset ID as the anchor.

This allows multiple changelogs to be shown in a single page.
jenkinsci · Jun 6, 2014 · 7d45efa · 7d45efa
1 parent fc36459
commit 7d45efa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly b/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly
@@ -6,15 +6,15 @@
 
   <h2>Summary</h2>
   <ol>
-    <j:forEach var="cs" items="${it.logs}" varStatus="loop">
-      <li>${cs.msgAnnotated} (<a href="#detail${loop.index}">details</a>)</li>
+    <j:forEach var="cs" items="${it.logs}">
+      <li>${cs.msgAnnotated} (<a href="#${cs.id}">details</a>)</li>
     </j:forEach>
   </ol>
   <table class="pane" style="border:none">
-    <j:forEach var="cs" items="${it.logs}" varStatus="loop">
+    <j:forEach var="cs" items="${it.logs}">
       <tr class="pane">
         <td colspan="2" class="changeset">
-          <a name="detail${loop.index}"></a>
+          <a name="${cs.id}"></a>
           <div class="changeset-message">
             <b>
               Commit

diff --git a/src/main/resources/hudson/plugins/git/GitSCM/project-changes.jelly b/src/main/resources/hudson/plugins/git/GitSCM/project-changes.jelly
@@ -47,8 +47,8 @@ THE SOFTWARE.
             (<i:formatDate value="${b.timestamp.time}" type="both" dateStyle="medium" timeStyle="medium"/>)</a></h2>
 
           <ol>
-            <j:forEach var="c" items="${changeSet.iterator()}" varStatus="loop">
-              <li value="${loop.index + 1}">
+            <j:forEach var="c" items="${changeSet.iterator()}">
+              <li>
                 ${c.msgAnnotated}
 
                 &#8212;
@@ -61,7 +61,7 @@ THE SOFTWARE.
                     <a href="${cslink}">${browser.descriptor.displayName}</a>
                   </j:when>
                   <j:otherwise>
-                    <a href="${b.number}/changes#detail${loop.index}">${%detail}</a>
+                    <a href="${b.number}/changes#${c.id}">${%detail}</a>
                   </j:otherwise>
                 </j:choose>
               </li>