do not run commit hooks in timing tests #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you are mandated to have something like `git secrets` installed then the test fails as it takes more time that the test allows to make the commit. On windows git secrets can easily make a commit take 20s to complete or more (but a lower bound is around 5 seconds). As we are doing timing here and we do not care about commit hooks, we can just skip them so they do not interfere.
jtnord
commented
Oct 1, 2021
| @@ -161,17 +161,17 @@ public void retrieveHeadsSupportsTagDiscovery_findTagsWithTagDiscoveryTrait() th | |||
| sampleRepo.init(); | |||
| sampleRepo.git("checkout", "-b", "dev"); | |||
| sampleRepo.write("file", "modified"); | |||
| sampleRepo.git("commit", "--all", "--message=dev-commit-message"); | |||
| sampleRepo.git("commit", "--all", "--message=dev-commit-message", "--no-verify"); | |||
| long beforeLightweightTag = System.currentTimeMillis(); | |||
There was a problem hiding this comment.
this should also not use currentTimeMillis but nonoTime as the clock can change during testing (NTP step or drifting) causing flaky tests - but well that can be left for another day :)
MarkEWaite
added
hacktoberfest-accepted
jtnord
added a commit
to jtnord/git-plugin
that referenced
this pull request
Jan 18, 2022
Similar to jenkinsci#1151 by default git comes without any hooks, but when creating a new sample git repo with the code it would copy the system default hooks, meaning this sample repo can behave differently on different platforms. by not using the hooks here we can avoid littering test code with "--no-verify" on commits, and can avoit hooks in other cases as well, which consume test time and / or even fail the operation due to a failing hook requirement (e.g. no JIRA reference) when consuming this in pipeline-model-definition's ValidatorTest test locally go from failing due to timeout exception (10 minutes) to completing in 2 minutes
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run commit hooks in timing test
if you are mandated to have something like
git secretsinstalled then the test fails as it takes more time that the test allows to make the commit.On windows git secrets can easily make a commit take 20s to complete or more (but a lower bound is around 5 seconds).
As we are doing timing here and we do not care about commit hooks, we can just skip them so they do not interfere.
Checklist
Types of changes