Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-14026] git plugin doesn't support branch name containing / #187

Merged
merged 1 commit into from
Jan 9, 2014

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jan 9, 2014

The main issue is to determine whether an input containing a slash is a
qualified branch (remote followed by branch name) or a branch name on
which the remote name needs to be prepended.

When there is only one remote involved, that can be solved by prepending
the remote name to the branch name if the branch name doesn't already
start with the remote name.

Note : This commit doesn't cover cases where the given branch name is a
pattern

slash ("/")

The main issue is to determine whether an input containing a slash is a
qualified branch (remote followed by branch name) or a branch name on
which the remote name needs to be prepended.

When there is only one remote involved, that can be solved by prepending
the remote name to the branch name if the branch name doesn't already
start with the remote name.

Note : This commit doesn't cover cases where the given branch name is a
pattern
@cloudbees-pull-request-builder

plugins » git-plugin #209 UNSTABLE
Looks like there's a problem with this pull request

ndeloof added a commit that referenced this pull request Jan 9, 2014
[FIXED JENKINS-14026] git plugin doesn't support branch name contains
@ndeloof ndeloof merged commit a67bbc0 into master Jan 9, 2014
@ndeloof
Copy link
Contributor

ndeloof commented Jan 9, 2014

For branches with slash in name, using FQN is anyway the recommended approach, you can't ask the plugin to discover everything

@ndeloof ndeloof deleted the JENKINS-14026 branch January 9, 2014 13:56
ndeloof added a commit that referenced this pull request Jan 22, 2014
This reverts commit a67bbc0, reversing
changes made to b75d1e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants