Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting obsolete encodeAllInputs function #402

Merged
merged 1 commit into from
May 21, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented May 20, 2016

As demonstrated in jenkinsci/workflow-cps-plugin#7, newer versions of HtmlUnit (which the 2.x plugin POM will pick up; cf. #390) will go berserk if they encounter a <script> directly inside <table> (i.e., between <tr>s). Always keep script inside <td> if you need it. This patch allows some configRoundtrip calls to succeed when using GitSCM.

In this case, the encodeAllInputs function seems to have not been used since 2.0: 61bd032 and 2d37646 deleted some usages but not the function itself. Anyway modern form binding does not require plugins to write JavaScript hacks like this. Just use field attributes, FormValidation with @QueryParameter and @RelativePath.

@reviewbybees

@armfergom
Copy link

🐝 Looked for more calls of encodeAllInputs but there weren't any indeed.

@KostyaSha
Copy link
Member

👍

@MarkEWaite MarkEWaite merged commit 5c043ac into jenkinsci:master May 21, 2016
@jglick jglick deleted the no-script-inside-table branch May 31, 2016 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants