Deleting obsolete encodeAllInputs function #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated in jenkinsci/workflow-cps-plugin#7, newer versions of HtmlUnit (which the 2.x plugin POM will pick up; cf. #390) will go berserk if they encounter a
<script>
directly inside<table>
(i.e., between<tr>
s). Always keep script inside<td>
if you need it. This patch allows someconfigRoundtrip
calls to succeed when usingGitSCM
.In this case, the
encodeAllInputs
function seems to have not been used since 2.0: 61bd032 and 2d37646 deleted some usages but not the function itself. Anyway modern form binding does not require plugins to write JavaScript hacks like this. Just usefield
attributes,FormValidation
with@QueryParameter
and@RelativePath
.@reviewbybees