Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-40382] GitSCMFileSystem mistakes #467

Merged
merged 2 commits into from Jan 14, 2017

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented Jan 13, 2017

Fixes a critical bug in #455 encountered during integration testing.

Might need a backport to a different branch, I do not follow that stuff.

@reviewbybees esp. @stephenc

@reviewbybees

This comment has been minimized.

Copy link

commented Jan 13, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2017

Seems like there is an infrastructure problem:

[Pipeline] [split0] node
[split0] Still waiting to schedule task
[split0] All nodes of label ‘highmem’ are offline
Cancelling nested steps due to timeout
@MarkEWaite

This comment has been minimized.

Copy link

commented Jan 13, 2017

Thanks for the catching that @jglick . I can handle the cherry pick to the 2.6.x branch. I think I've seen that NPE in other contexts, and have been working around it by always assigning a credential (even if it is an invalid credential)

@jglick jglick changed the title [JENKINS-40382] NPE from build when no credentialsId is defined [JENKINS-40382] GitSCMFileSystem mistakes Jan 13, 2017

@MarkEWaite MarkEWaite merged commit f57167e into jenkinsci:master Jan 14, 2017

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:CredentialsMatchers.withId-NPE branch Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.