[JENKINS-38827] Track credentials use #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were easy cases because CredentialsProvider.track() arguments were available in the method where credentials were added. It is expected that there are still cases where credentials are not tracked correctly by the plugin. Credential checks from the job definition page are probably not currently tracked. Other contexts (like pipeline) may also not be tracked by these changes.
MarkEWaite
changed the title
This was referenced Apr 18, 2017
Tracking credentials at the build level shows the build which used those credentials, and still retains the visual association with the project which defined the build.
Extends testRepo with credentials. Uses existing credentials arguments in UserRemoteConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were easy cases because CredentialsProvider.track() arguments were available in the method where credentials were added.
There are still cases where credentials are not tracked correctly by the plugin. Credential checks from the job definition page are not currently tracked. Other contexts (like pipeline) may also not be tracked by these changes.
I've resolved the issue shown in the attached output (circled in red) in 588d898. The earlier code was using the project that was available in the GitSCM object. I changed it to use project.lastBuild() instead. The tests in the credentials plugin were a great guide to understand and resolve my mistake.