Remove test dependency on multiple-scms plugin #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
force-pushed
the
make-plugin-testable-hpi-run
branch
from
606753b
to
f4ab92a
Compare
MarkEWaite
approved these changes
Nov 4, 2020
MarkEWaite
changed the title
I had kept promoted builds plugin at an older version for fear of forcing users to a newer version that might have compatibility issues. Several releases of the promoted builds plugin had issues that prevented user upgrades. However, the current stats show that the users of promoted-builds plugin that are on Jenkins 2.204.1 or newer (minimum version supported by git plugin) have almost all upgraded to promoted builds plugin 3.5. If they've upgraded to 3.5, then they've already upgraded past the versions that had issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://issues.jenkins-ci.org/browse/JENKINS-64136 although doesn't fix it
Without these changes you can't run this plugin using
hpi:runon 2.264.At least 3.6 for promoted builds is needed to pickup a tables to divs fix
and multiple-scms is deprecated and abandoned, it's very broken... (including broken on tables to div although broken before that as well)