Apply routine updates to fix PCT with more recent Jenkins versions and JDK11 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update jenkins.version to 2.277.1 * Update matching bom * Update maven wrapper to a current version
Vlatombe
changed the title
amuniz
approved these changes
Feb 11, 2022
aHenryJard
approved these changes
Feb 11, 2022
kerogers-cloudbees
approved these changes
Feb 11, 2022
twasyl
approved these changes
Feb 14, 2022
|
@oleg-nenashev @lanwen Any chance you could trigger a release? |
KostyaSha
reviewed
Feb 15, 2022
src/test/java/org/jenkinsci/plugins/github/config/GitHubServerConfigTest.java
Outdated
Show resolved
Hide resolved
This reverts commit d36d9a3.
jtnord
approved these changes
Feb 24, 2022
| @@ -13,6 +12,7 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.Collection; | |||
| import java.util.List; | |||
| import wiremock.org.eclipse.jetty.http.HttpStatus; | |||
There was a problem hiding this comment.
NIT: generally I would not rely on on internal implementations, but use java.net.HttpURLConnection.HTTP_CREATED, but this was existing anyway.
…va.net.HttpURLConnection instead.
|
hope squash merge is not a problem for everyone |
|
@KostyaSha Can you release this plugin? Or do you know who can so I can ask them? |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlaps with #261 so maintainer will need to pick one of these (this PR being more conservative using an older Jenkins baseline, but doesn't cover the guava upgrade)