Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

room setting and notification selection should be per post-build task, not per build #29

Closed
jikamens opened this issue Jan 2, 2015 · 2 comments
Assignees
Milestone

Comments

@jikamens
Copy link

jikamens commented Jan 2, 2015

Right now there's a HipChat configuration setting in each build, where you specify the room (to override the default) and which notifications to send, regardless of whether the HipChat post-build action is enabled for the build.

This configuration should be per-post-build-action, not per-build, for two reasons:

  1. It is quite misleading to have that configuration at the top of the build configuration page when it doesn't actually do anything unless there is a HipChat post-build action configured for the build.
  2. Putting the config per-action rather than per-build would allow different types of notifications to be sent to different rooms.
@aldaris
Copy link

aldaris commented Jan 2, 2015

I believe this is already resolved with bb103a3.

@aldaris aldaris added this to the 0.1.9 milestone Feb 22, 2015
@aldaris aldaris self-assigned this Feb 22, 2015
@aldaris
Copy link

aldaris commented Feb 22, 2015

Feel free to check out the latest nightly, should work much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants